From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Matteo Croce <mcroce@linux.microsoft.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Lemon <jonathan.lemon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
David Ahern <dsahern@gmail.com>,
Saeed Mahameed <saeed@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling
Date: Fri, 9 Apr 2021 23:34:43 +0300 [thread overview]
Message-ID: <YHC6Y0jSte0fWygK@apalos.home> (raw)
In-Reply-To: <20210409122929.5c2793df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Apr 09, 2021 at 12:29:29PM -0700, Jakub Kicinski wrote:
> On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote:
> > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote:
> > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote:
> > > > Co-developed-by: Jesper Dangaard Brouer <brouer@redhat.com>
> > > > Co-developed-by: Matteo Croce <mcroce@microsoft.com>
> > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > >
> > > Checkpatch says we need sign-offs from all authors.
> > > Especially you since you're posting.
> >
> > Yes it does, we forgot that. Let me take a chance on this one.
> > The patch is changing the default skb return path and while we've done enough
> > testing, I would really prefer this going in on a future -rc1 (assuming we even
> > consider merging it), allowing enough time to have wider tests.
>
> Up to you guys. FWIW if you decide to try for 5.13 the missing signoffs
> can be posted in replies, no need to repost.
Thanks! but...
I think I prefer another repost, including mm-people on the list as well (and
fixing SoB's).
I just noticed noone is cc'ed and patch [2/5] adds a line in mm_types.h
/Ilias
next prev parent reply other threads:[~2021-04-09 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 18:17 [PATCH net-next v2 0/5] page_pool: recycle buffers Matteo Croce
2021-04-02 18:17 ` [PATCH net-next v2 1/5] xdp: reduce size of struct xdp_mem_info Matteo Croce
2021-04-02 18:17 ` [PATCH net-next v2 2/5] mm: add a signature in struct page Matteo Croce
2021-04-02 18:17 ` [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling Matteo Croce
2021-04-09 18:56 ` Jakub Kicinski
2021-04-09 19:01 ` Ilias Apalodimas
2021-04-09 19:29 ` Jakub Kicinski
2021-04-09 20:34 ` Ilias Apalodimas [this message]
2021-04-09 20:40 ` Jesper Dangaard Brouer
2021-04-02 18:17 ` [PATCH net-next v2 4/5] mvpp2: recycle buffers Matteo Croce
2021-04-02 18:17 ` [PATCH net-next v2 5/5] mvneta: " Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHC6Y0jSte0fWygK@apalos.home \
--to=ilias.apalodimas@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=hawk@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.