Re: [RFC PATCH 0/4] target/ppc: add disable-tcg option

From: David Gibson <david@gibson.dropbear.id.au>
To: "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br>
Cc: qemu-devel@nongnu.org, andre.silva@eldorado.org.br,
	lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br,
	qemu-ppc@nongnu.org, lagarcia@br.ibm.com,
	matheus.ferst@eldorado.org.br, luis.pires@eldorado.org.br
Subject: Re: [RFC PATCH 0/4] target/ppc: add disable-tcg option
Date: Mon, 12 Apr 2021 14:32:21 +1000	[thread overview]
Message-ID: <YHPNVUlnHWu5rU+I@yekko.fritz.box> (raw)
In-Reply-To: <20210409151916.97326-1-bruno.larsen@eldorado.org.br>

[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]

For future reference, please CC me explicitly on things you'd like me
to review.  I do scan the qemu-ppc@nongnu.org list, but it makes it
easier for me to find (and less likely that I'll accidentally overlook
it) if I'm also CCed directly.

On Fri, Apr 09, 2021 at 12:19:12PM -0300, Bruno Larsen (billionai) wrote:
> This patch series aims to add the option to build without TCG for the
> powerpc target. This RFC shows mostly the strategies employed when
> dealing with compilation problems, and ask for input on the bits
> we don't quite understand yet.
> 
> The first patch mostly code motion, as referenced in 2021-04/msg0717.
> The second patch shows the 2 strategies we've considered, and hope to
> get feedback on. The third patch contains the stubs we haven't decided
> on how to deal with yet, but needed to exist to compile the project.
> The final patch just changes the meson.build rules
> 
> Bruno Larsen (billionai) (4):
>   target/ppc: Code motion required to build disabling tcg
>   target/ppc: added solutions for problems encountered when building
>     with disable-tcg
>   target/ppc: Add stubs for tcg functions, so it build with disable-tcg
>   target/ppc: updated build rules for disable-tcg option
> 
>  target/ppc/arch_dump.c          |   17 +
>  target/ppc/cpu.c                |  859 +++++++++++++++++++++++
>  target/ppc/cpu.h                |   15 +
>  target/ppc/gdbstub.c            |  253 +++++++
>  target/ppc/kvm.c                |   30 +
>  target/ppc/kvm_ppc.h            |   11 +
>  target/ppc/machine.c            |   33 +-
>  target/ppc/meson.build          |   22 +-
>  target/ppc/tcg-stub.c           |  139 ++++
>  target/ppc/translate_init.c.inc | 1148 +------------------------------
>  10 files changed, 1407 insertions(+), 1120 deletions(-)
>  create mode 100644 target/ppc/tcg-stub.c
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]