From: Michal Hocko <mhocko@suse.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
David Hildenbrand <david@redhat.com>,
Muchun Song <songmuchun@bytedance.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality
Date: Tue, 13 Apr 2021 15:24:32 +0200 [thread overview]
Message-ID: <YHWbkNqLsNht6who@dhcp22.suse.cz> (raw)
In-Reply-To: <20210413104747.12177-5-osalvador@suse.de>
On Tue 13-04-21 12:47:44, Oscar Salvador wrote:
[...]
> +static void prep_new_huge_page(struct hstate *h, struct page *page, int nid)
> +{
> + __prep_new_huge_page(page);
> spin_lock_irq(&hugetlb_lock);
> - h->nr_huge_pages++;
> - h->nr_huge_pages_node[nid]++;
> + __prep_account_new_huge_page(h, nid);
> spin_unlock_irq(&hugetlb_lock);
> }
Any reason to decouple the locking from the accounting?
>
> --
> 2.16.3
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-04-13 13:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 10:47 [PATCH v7 0/7] Make alloc_contig_range handle Hugetlb pages Oscar Salvador
2021-04-13 10:47 ` [PATCH v7 1/7] mm,page_alloc: Bail out earlier on -ENOMEM in alloc_contig_migrate_range Oscar Salvador
2021-04-13 17:00 ` Mike Kravetz
2021-04-13 10:47 ` [PATCH v7 2/7] mm,compaction: Let isolate_migratepages_{range,block} return error codes Oscar Salvador
2021-04-13 17:52 ` Mike Kravetz
2021-04-14 11:54 ` David Hildenbrand
2021-04-15 8:42 ` Oscar Salvador
2021-04-13 10:47 ` [PATCH v7 3/7] mm,hugetlb: Clear HPageFreed outside of the lock Oscar Salvador
2021-04-13 13:23 ` Michal Hocko
2021-04-13 21:19 ` Mike Kravetz
2021-04-14 6:04 ` Michal Hocko
2021-04-14 7:41 ` Oscar Salvador
2021-04-14 8:28 ` Michal Hocko
2021-04-14 10:01 ` Oscar Salvador
2021-04-14 10:03 ` Oscar Salvador
2021-04-14 10:32 ` Michal Hocko
2021-04-14 10:49 ` Oscar Salvador
2021-04-14 11:09 ` Michal Hocko
2021-04-14 12:02 ` David Hildenbrand
2021-04-14 16:45 ` Mike Kravetz
2021-04-13 10:47 ` [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality Oscar Salvador
2021-04-13 13:24 ` Michal Hocko [this message]
2021-04-13 13:26 ` Michal Hocko
2021-04-13 21:33 ` Mike Kravetz
2021-04-14 4:59 ` Oscar Salvador
2021-04-14 12:15 ` David Hildenbrand
2021-04-14 17:03 ` Mike Kravetz
2021-04-13 10:47 ` [PATCH v7 5/7] mm: Make alloc_contig_range handle free hugetlb pages Oscar Salvador
2021-04-13 13:40 ` Michal Hocko
2021-04-15 8:29 ` Oscar Salvador
2021-04-13 22:29 ` Mike Kravetz
2021-04-14 4:54 ` Oscar Salvador
2021-04-14 12:26 ` David Hildenbrand
2021-04-15 8:28 ` Oscar Salvador
2021-04-13 10:47 ` [PATCH v7 6/7] mm: Make alloc_contig_range handle in-use " Oscar Salvador
2021-04-13 22:48 ` Mike Kravetz
2021-04-14 4:52 ` Oscar Salvador
2021-04-14 17:07 ` Mike Kravetz
2021-04-13 10:47 ` [PATCH v7 7/7] mm,page_alloc: Drop unnecessary checks from pfn_range_valid_contig Oscar Salvador
2021-04-13 22:53 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHWbkNqLsNht6who@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.