Re: [PATCH v4 00/31] Base for adding PowerPC 64-bit instructions

From: David Gibson <david@gibson.dropbear.id.au>
To: matheus.ferst@eldorado.org.br
Cc: richard.henderson@linaro.org, qemu-devel@nongnu.org,
	f4bug@amsat.org, luis.pires@eldorado.org.br, qemu-ppc@nongnu.org,
	lagarcia@br.ibm.com, bruno.larsen@eldorado.org.br
Subject: Re: [PATCH v4 00/31] Base for adding PowerPC 64-bit instructions
Date: Thu, 13 May 2021 14:22:44 +1000	[thread overview]
Message-ID: <YJyplOJUjBWrJyZJ@yekko> (raw)
In-Reply-To: <20210512185441.3619828-1-matheus.ferst@eldorado.org.br>

[-- Attachment #1: Type: text/plain, Size: 4500 bytes --]

On Wed, May 12, 2021 at 03:54:10PM -0300, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
> 
> This series provides the basic infrastructure for adding the new 32/64-bit
> instructions in Power ISA 3.1 to target/ppc.

I've applied the first chunk of these.  After that I get conflicts
with my current ppc-for-6.1 tree.  I suspect those are conflicts with
the !TCG changes I recently applied as well.

In any case, please rebase the remainder and resend.

> 
> v4:
> - Rebase on ppc-for-6.1;
> - Fold do_ldst_D and do_ldst_X;
> - Add tcg_const_tl, used to share do_ldst_D and do_ldst_X code;
> - Unfold prefixed and non-prefixed loads/stores/addi to let non-prefixed insns use the non-prefixed formats;
> - PNOP invalid suffixes;
> - setbc/setbcr/stnbc/setnbcr implemented;
> - cfuged/vcfuged implemented;
> - addpcis moved to decodetree.
> 
> v3:
> - More changes for decodetree.
> - Cleanup exception/is_jmp logic to the point exception is removed.
> - Fold in Luis' isa check for prefixed insn support.
> - Share trans_* between prefixed and non-prefixed instructions.
> - Use macros to minimize the trans_* boilerplate.
> - Fix decode mistake for STHX/STHXU.
> 
> v2:
> - Store current pc in ctx instead of insn_size
> - Use separate decode files for 32- and 64-bit instructions
> - Improvements to the exception/is_jmp logic
> - Use translator_loop_temp_check()
> - Moved logic to prevent translation from crossing page boundaries
> - Additional instructions using decodetree: addis, pnop, loads/stores
> - Added check for prefixed insn support in cpu flags
> 
> Matheus Ferst (6):
>   target/ppc: Introduce gen_icount_io_start
>   TCG: add tcg_constant_tl
>   target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions
>   target/ppc: Implement cfuged instruction
>   target/ppc: Implement vcfuged instruction
>   target/ppc: Move addpcis to decodetree
> 
> Richard Henderson (25):
>   target/ppc: Add cia field to DisasContext
>   target/ppc: Split out decode_legacy
>   target/ppc: Move DISAS_NORETURN setting into gen_exception*
>   target/ppc: Remove special case for POWERPC_SYSCALL
>   target/ppc: Remove special case for POWERPC_EXCP_TRAP
>   target/ppc: Simplify gen_debug_exception
>   target/ppc: Introduce DISAS_{EXIT,CHAIN}{,_UPDATE}
>   target/ppc: Replace POWERPC_EXCP_SYNC with DISAS_EXIT
>   target/ppc: Remove unnecessary gen_io_end calls
>   target/ppc: Replace POWERPC_EXCP_STOP with DISAS_EXIT_UPDATE
>   target/ppc: Replace POWERPC_EXCP_BRANCH with DISAS_NORETURN
>   target/ppc: Remove DisasContext.exception
>   target/ppc: Move single-step check to ppc_tr_tb_stop
>   target/ppc: Tidy exception vs exit_tb
>   target/ppc: Mark helper_raise_exception* as noreturn
>   target/ppc: Use translator_loop_temp_check
>   target/ppc: Introduce macros to check isa extensions
>   target/ppc: Move page crossing check to ppc_tr_translate_insn
>   target/ppc: Add infrastructure for prefixed insns
>   target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI
>   target/ppc: Implement PNOP
>   target/ppc: Move D/DS/X-form integer loads to decodetree
>   target/ppc: Implement prefixed integer load instructions
>   target/ppc: Move D/DS/X-form integer stores to decodetree
>   target/ppc: Implement prefixed integer store instructions
> 
>  include/tcg/tcg-op.h                       |   2 +
>  linux-user/ppc/cpu_loop.c                  |   6 -
>  target/ppc/cpu.h                           |   5 +-
>  target/ppc/helper.h                        |   5 +-
>  target/ppc/insn32.decode                   | 112 +++
>  target/ppc/insn64.decode                   | 123 +++
>  target/ppc/int_helper.c                    |  39 +
>  target/ppc/meson.build                     |   9 +
>  target/ppc/translate.c                     | 829 ++++++++-------------
>  target/ppc/translate/fixedpoint-impl.c.inc | 243 ++++++
>  target/ppc/translate/vector-impl.c.inc     |  50 ++
>  11 files changed, 877 insertions(+), 546 deletions(-)
>  create mode 100644 target/ppc/insn32.decode
>  create mode 100644 target/ppc/insn64.decode
>  create mode 100644 target/ppc/translate/fixedpoint-impl.c.inc
>  create mode 100644 target/ppc/translate/vector-impl.c.inc
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]