All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Corentin Chary <corentin.chary@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <mgross@linux.intel.com>,
	Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] platform/x86: samsung-laptop: use octal numbers for rwx file permissions
Date: Mon, 17 May 2021 12:02:04 +0200	[thread overview]
Message-ID: <YKI/HD7qZB6Seh/+@ninjato> (raw)
In-Reply-To: <CAHp75VdSv4Ja7+bjPDvOawuv1ukhKZ==bjQ_MQbNPUds_7mVZw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]


> > > -       debugfs_create_file("call", S_IFREG | S_IRUGO, root, samsung,
> > > +       debugfs_create_file("call", S_IFREG | 0444, root, samsung,
> 
> Actually you may drop IFREG as well as debugfs will add it if there is
> no conflicting file type defined.

Oh, I missed this back then. Quoting only relevant parts of a message
helps me to avoid that ;)

I will add this, to patch 2, though. This is only a plain conversion. v3
coming in a minute.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-05-17 10:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 17:00 [PATCH v2 1/2] platform/x86: samsung-laptop: use octal numbers for rwx file permissions Wolfram Sang
2021-05-04 17:00 ` [PATCH v2 2/2] platform/x86: samsung-laptop: set debugfs blobs to read only Wolfram Sang
2021-05-04 17:38   ` Andy Shevchenko
2021-05-04 18:10     ` Wolfram Sang
2021-05-04 17:35 ` [PATCH v2 1/2] platform/x86: samsung-laptop: use octal numbers for rwx file permissions Andy Shevchenko
2021-05-04 17:37   ` Andy Shevchenko
2021-05-17 10:02     ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKI/HD7qZB6Seh/+@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.