From: Nathan Chancellor <nathan@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: x86@kernel.org, Sami Tolvanen <samitolvanen@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
clang-built-linux@googlegroups.com,
Anthony Ruhier <aruhier@mailbox.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Fix location of '-plugin-opt=' flags
Date: Fri, 21 May 2021 11:31:54 -0700 [thread overview]
Message-ID: <YKf8mvg4diHLSJDt@archlinux-ax161> (raw)
In-Reply-To: <162161994470.2028902.331062863146834934.b4-ty@chromium.org>
On Fri, May 21, 2021 at 10:59:10AM -0700, Kees Cook wrote:
> On Tue, 18 May 2021 12:01:06 -0700, Nathan Chancellor wrote:
> > Commit b33fff07e3e3 ("x86, build: allow LTO to be selected") added a
> > couple of '-plugin-opt=' flags to KBUILD_LDFLAGS because the code model
> > and stack alignment are not stored in LLVM bitcode. However, these flags
> > were added to KBUILD_LDFLAGS prior to the emulation flag assignment,
> > which uses ':=', so they were overwritten and never added to $(LD)
> > invocations. The absence of these flags caused misalignment issues in
> > the AMDGPU driver when compiling with CONFIG_LTO_CLANG, resulting in
> > general protection faults.
> >
> > [...]
>
> (I've slightly adjusted the title.)
>
> Applied to for-next/clang/features, thanks!
>
> [1/1] x86: lto: Fix location of '-plugin-opt=' flags
> https://git.kernel.org/kees/c/5d6c8592ee5f
>
Ingo picked this up in x86/urgent so you should not need to carry it.
https://git.kernel.org/tip/0024430e920f2900654ad83cd081cf52e02a3ef5
Cheers,
Nathan
next prev parent reply other threads:[~2021-05-21 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 19:01 [PATCH] x86: Fix location of '-plugin-opt=' flags Nathan Chancellor
2021-05-18 20:24 ` Nick Desaulniers
2021-05-19 11:23 ` [tip: x86/urgent] x86/build: " tip-bot2 for Nathan Chancellor
2021-05-21 17:59 ` [PATCH] x86: " Kees Cook
2021-05-21 18:31 ` Nathan Chancellor [this message]
2021-05-21 21:04 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKf8mvg4diHLSJDt@archlinux-ax161 \
--to=nathan@kernel.org \
--cc=aruhier@mailbox.org \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.