From: Kent Overstreet <kent.overstreet@gmail.com>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: Eryu Guan <guan@eryu.me>,
fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-bcachefs@vger.kernel.org,
Kent Overstreet <kmo@daterainc.com>
Subject: Re: [PATCH 1/3] Initial bcachefs support
Date: Mon, 24 May 2021 00:48:53 -0400 [thread overview]
Message-ID: <YKswNcbS2DhaeEOS@moria.home.lan> (raw)
In-Reply-To: <20210524042253.GE60846@e18g06458.et15sqa>
On Mon, May 24, 2021 at 12:22:53PM +0800, Eryu Guan wrote:
> Oh, I noticed that "with bcachefs fsck finding errors _always_ indicates
> a bug" now.. Then I think using fsck -n is fine here, but better with
> comments to describe why this is ok for bcachefs.
>
> Also, we could just use _check_scratch_fs here instead of the open-coded
> fsck command. As _check_scratch_fs calls _check_generic_filesystem()
> which calls fsck -n internally, and handles mount/umount device
> correctly and prints pretty log if there's any errors.
That should work.
next prev parent reply other threads:[~2021-05-24 4:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 16:44 [PATCH 0/3] bcachefs support Kent Overstreet
2021-04-27 16:44 ` [PATCH 1/3] Initial " Kent Overstreet
2021-05-09 14:36 ` Eryu Guan
2021-05-23 22:51 ` Kent Overstreet
2021-05-24 3:56 ` Eryu Guan
2021-05-24 4:04 ` Kent Overstreet
2021-05-24 4:22 ` Eryu Guan
2021-05-24 4:48 ` Kent Overstreet [this message]
2021-04-27 16:44 ` [PATCH 2/3] Improved .gitignore Kent Overstreet
2021-04-27 16:44 ` [PATCH 3/3] Use --yes option to lvcreate Kent Overstreet
2021-04-27 17:03 ` Eryu Guan
2021-04-27 20:29 ` Kent Overstreet
2021-04-27 20:43 ` Matthew Wilcox
2021-04-27 21:02 ` Eric Biggers
2021-04-27 21:18 ` Kent Overstreet
2021-05-09 14:20 ` [PATCH 0/3] bcachefs support Eryu Guan
2021-05-10 23:14 ` Dave Chinner
2021-05-11 1:26 ` Darrick J. Wong
2021-05-16 13:54 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKswNcbS2DhaeEOS@moria.home.lan \
--to=kent.overstreet@gmail.com \
--cc=eguan@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=kmo@daterainc.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.