From: Emily Shaffer <emilyshaffer@google.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
sandals@crustytoothpaste.net, stolee@gmail.com,
jrnieder@gmail.com, Derrick Stolee <derrickstolee@github.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 2/4] *: use singular they in comments
Date: Tue, 8 Jun 2021 10:36:17 -0700 [thread overview]
Message-ID: <YL+qkVXGMzg8S9gp@google.com> (raw)
In-Reply-To: <b36e3f99716bf3976fc886df684c300e17566c79.1623085069.git.gitgitgadget@gmail.com>
On Mon, Jun 07, 2021 at 04:57:46PM +0000, Derrick Stolee via GitGitGadget wrote:
>
>
> Several comments in our code refer to an anonymous user with "he/him" or
> "she/her" pronouns, and the choice between the two is arbitrary.
>
> Replace these uses with "they/them" which universally includes all
> potential readers.
Thanks. I'm especially glad to see the codebase start to unify instead
of awkwardly choosing between "he", "she", "he or she", or even "(s)he".
This seems a lot neater.
Reviewed-by: Emily Shaffer <emilyshaffer@google.com>
next prev parent reply other threads:[~2021-06-08 17:37 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 16:57 [PATCH 0/4] Use singular "they" when appropriate Derrick Stolee via GitGitGadget
2021-06-07 16:57 ` [PATCH 1/4] Documentation: use singular they " Derrick Stolee via GitGitGadget
2021-06-07 17:09 ` Ævar Arnfjörð Bjarmason
2021-06-07 17:32 ` Derrick Stolee
2021-06-07 17:42 ` Andrei Rybak
2021-06-07 18:21 ` Ævar Arnfjörð Bjarmason
2021-06-10 7:44 ` Johannes Schindelin
2021-06-10 14:35 ` Felipe Contreras
2021-06-07 21:36 ` Felipe Contreras
2021-06-09 18:47 ` Phillip Susi
2021-06-09 20:26 ` Felipe Contreras
2021-06-11 15:40 ` Phillip Susi
2021-06-11 17:03 ` Felipe Contreras
2021-06-10 18:30 ` Derrick Stolee
2021-06-11 0:16 ` Junio C Hamano
2021-06-11 16:00 ` Felipe Contreras
2021-06-12 14:02 ` Phillip Susi
2021-06-08 1:18 ` Junio C Hamano
2021-06-08 8:51 ` Kerry, Richard
2021-06-08 23:21 ` Junio C Hamano
2021-06-09 13:13 ` Derrick Stolee
2021-06-10 3:11 ` Junio C Hamano
2021-06-08 17:33 ` Emily Shaffer
2021-06-08 18:03 ` Felipe Contreras
2021-06-09 13:44 ` Kerry, Richard
2021-06-09 17:44 ` Felipe Contreras
2021-06-25 14:30 ` Kerry, Richard
2021-06-09 4:48 ` Junio C Hamano
2021-06-10 8:18 ` Johannes Schindelin
2021-06-10 14:42 ` Felipe Contreras
2021-06-14 22:10 ` Robert Karszniewicz
2021-06-07 16:57 ` [PATCH 2/4] *: use singular they in comments Derrick Stolee via GitGitGadget
2021-06-07 17:12 ` Ævar Arnfjörð Bjarmason
2021-06-07 17:20 ` Derrick Stolee
2021-06-10 8:20 ` Johannes Schindelin
2021-06-07 19:02 ` Junio C Hamano
2021-06-07 21:44 ` Felipe Contreras
2021-06-08 17:36 ` Emily Shaffer [this message]
2021-06-07 16:57 ` [PATCH 3/4] *: fix typos Derrick Stolee via GitGitGadget
2021-06-08 17:37 ` Emily Shaffer
2021-06-10 8:36 ` Johannes Schindelin
2021-06-10 19:53 ` Derrick Stolee
2021-06-11 9:55 ` Johannes Schindelin
2021-06-07 16:57 ` [PATCH 4/4] CodingGuidelines: recommend singular they Derrick Stolee via GitGitGadget
2021-06-07 18:31 ` Ævar Arnfjörð Bjarmason
2021-06-08 1:47 ` Felipe Contreras
2021-06-07 18:56 ` Junio C Hamano
2021-06-07 19:05 ` Derrick Stolee
2021-06-08 0:05 ` Junio C Hamano
2021-06-10 21:34 ` brian m. carlson
2021-06-10 8:39 ` Johannes Schindelin
2021-06-07 20:00 ` Felipe Contreras
2021-06-09 18:29 ` Phillip Susi
2021-06-09 20:18 ` Felipe Contreras
2021-06-07 20:20 ` Robert Karszniewicz
2021-06-07 22:18 ` Felipe Contreras
2021-06-08 7:10 ` Jeff King
2021-06-08 8:11 ` Felipe Contreras
2021-06-09 13:23 ` Derrick Stolee
2021-06-09 15:20 ` Felipe Contreras
2021-06-10 22:06 ` brian m. carlson
2021-06-11 16:11 ` Felipe Contreras
2021-06-08 17:39 ` Emily Shaffer
2021-06-09 4:44 ` Junio C Hamano
2021-06-09 13:27 ` Derrick Stolee
2021-06-07 20:10 ` [PATCH 0/4] Use singular "they" when appropriate Felipe Contreras
2021-06-09 13:54 ` [PATCH v2 " Derrick Stolee via GitGitGadget
2021-06-09 13:54 ` [PATCH v2 1/4] Documentation: use singular they " Derrick Stolee via GitGitGadget
2021-06-09 15:33 ` Felipe Contreras
2021-06-09 13:54 ` [PATCH v2 2/4] *: use singular they in comments Derrick Stolee via GitGitGadget
2021-06-09 15:41 ` Felipe Contreras
2021-06-09 13:54 ` [PATCH v2 3/4] *: fix typos Derrick Stolee via GitGitGadget
2021-06-09 13:54 ` [PATCH v2 4/4] CodingGuidelines: recommend singular they Derrick Stolee via GitGitGadget
2021-06-09 15:50 ` Felipe Contreras
2021-06-09 15:44 ` [PATCH v2 0/4] Use singular "they" when appropriate Ævar Arnfjörð Bjarmason
2021-06-09 17:22 ` Felipe Contreras
2021-06-10 2:03 ` Junio C Hamano
2021-06-10 2:28 ` Junio C Hamano
2021-06-10 3:30 ` Felipe Contreras
2021-06-10 22:32 ` brian m. carlson
2021-06-10 22:58 ` Ævar Arnfjörð Bjarmason
2021-06-11 16:32 ` Felipe Contreras
2021-06-11 17:18 ` Derrick Stolee
2021-06-11 20:38 ` Felipe Contreras
2021-06-13 7:17 ` Ævar Arnfjörð Bjarmason
2021-06-15 6:02 ` Junio C Hamano
2021-06-15 13:36 ` Derrick Stolee
2021-06-15 17:03 ` Felipe Contreras
2021-06-14 0:47 ` Junio C Hamano
2021-06-15 14:11 ` [PATCH v3 0/4] Avoid gendered pronouns Derrick Stolee via GitGitGadget
2021-06-15 14:11 ` [PATCH v3 1/4] doc: avoid using the gender of other people Felipe Contreras via GitGitGadget
2021-06-15 14:11 ` [PATCH v3 2/4] comments: avoid using the gender of our users Felipe Contreras via GitGitGadget
2021-06-15 14:11 ` [PATCH v3 3/4] *: fix typos Derrick Stolee via GitGitGadget
2021-06-15 14:11 ` [PATCH v3 4/4] CodingGuidelines: recommend singular they Derrick Stolee via GitGitGadget
2021-06-15 16:19 ` Ævar Arnfjörð Bjarmason
2021-06-15 17:26 ` Felipe Contreras
2021-06-16 2:47 ` Junio C Hamano
2021-06-16 5:06 ` Junio C Hamano
2021-06-16 9:26 ` Bagas Sanjaya
2021-06-16 17:44 ` Derrick Stolee
2021-06-16 19:54 ` Ævar Arnfjörð Bjarmason
2021-06-16 23:22 ` Felipe Contreras
2021-06-17 0:09 ` Junio C Hamano
2021-06-17 13:22 ` Derrick Stolee
2021-06-17 14:53 ` Ævar Arnfjörð Bjarmason
2021-06-17 17:06 ` Felipe Contreras
2021-06-17 15:25 ` Felipe Contreras
2021-06-18 0:26 ` brian m. carlson
2021-06-18 16:12 ` Felipe Contreras
2021-06-17 15:23 ` Felipe Contreras
2021-06-17 15:58 ` Ævar Arnfjörð Bjarmason
2021-06-18 0:53 ` brian m. carlson
2021-06-18 7:24 ` Ævar Arnfjörð Bjarmason
2021-06-18 16:40 ` Felipe Contreras
2021-06-19 7:03 ` Junio C Hamano
2021-06-28 22:32 ` Junio C Hamano
2021-06-29 1:31 ` Felipe Contreras
2021-06-29 1:53 ` Derrick Stolee
2021-06-29 12:29 ` Ævar Arnfjörð Bjarmason
2021-06-17 15:12 ` Felipe Contreras
2021-06-17 14:46 ` Felipe Contreras
2021-06-15 17:08 ` Felipe Contreras
2021-06-12 4:40 ` [PATCH 0/4] Use singular "they" when appropriate Bagas Sanjaya
2021-06-12 14:19 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL+qkVXGMzg8S9gp@google.com \
--to=emilyshaffer@google.com \
--cc=derrickstolee@github.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.