From: Davide Caratti <dcaratti@redhat.com>
To: Boris Sukholitko <boris.sukholitko@broadcom.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Cong Wang <xiyou.wangcong@gmail.com>,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
Ilya Lifshits <ilya.lifshits@broadcom.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v3 0/3] net/sched: act_vlan: Fix modify to allow 0
Date: Mon, 31 May 2021 13:57:07 +0200 [thread overview]
Message-ID: <YLTPEzvYsUmxOIr9@dcaratti.users.ipa.redhat.com> (raw)
In-Reply-To: <20210530114052.16483-1-boris.sukholitko@broadcom.com>
On Sun, May 30, 2021 at 02:40:49PM +0300, Boris Sukholitko wrote:
> Currently vlan modification action checks existence of vlan priority by
> comparing it to 0. Therefore it is impossible to modify existing vlan
> tag to have priority 0.
hello Boris, thanks for following up!
> Change Log:
> v2 -> v3:
> - Push assumes that the priority is being set
> - tcf_vlan_get_fill_size accounts for priority existence
Reviewed-by: Davide Caratti <dcaratti@redhat.com>
next prev parent reply other threads:[~2021-05-31 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 11:40 [PATCH net-next v3 0/3] net/sched: act_vlan: Fix modify to allow 0 Boris Sukholitko
2021-05-30 11:40 ` Boris Sukholitko
2021-05-30 11:40 ` [PATCH net-next v3 1/3] " Boris Sukholitko
2021-05-30 11:40 ` [PATCH net-next v3 2/3] net/sched: act_vlan: No dump for unset priority Boris Sukholitko
2021-06-01 5:21 ` Jakub Kicinski
2021-06-01 12:35 ` Boris Sukholitko
2021-06-01 12:48 ` Davide Caratti
2021-05-30 11:40 ` [PATCH net-next v3 3/3] net/sched: act_vlan: Test priority 0 modification Boris Sukholitko
2021-05-30 11:40 ` Boris Sukholitko
2021-05-31 11:57 ` Davide Caratti [this message]
2021-05-31 12:13 ` [PATCH net-next v3 0/3] net/sched: act_vlan: Fix modify to allow 0 Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLTPEzvYsUmxOIr9@dcaratti.users.ipa.redhat.com \
--to=dcaratti@redhat.com \
--cc=boris.sukholitko@broadcom.com \
--cc=ilya.lifshits@broadcom.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=shuah@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.