From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH 5/9] nvmem: core: add a missing of_node_put
Date: Fri, 11 Jun 2021 10:57:14 +0200 [thread overview]
Message-ID: <YMMlalfdeIW4W1RC@kroah.com> (raw)
In-Reply-To: <20210611083348.20170-6-srinivas.kandagatla@linaro.org>
On Fri, Jun 11, 2021 at 09:33:44AM +0100, Srinivas Kandagatla wrote:
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> 'for_each_child_of_node' performs an of_node_get on each iteration, so a
> return from the middle of the loop requires an of_node_put.
>
> Fixes: e888d445ac33 ("nvmem: resolve cells from DT at registration time")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/nvmem/core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Looks like this needs to go to the stable kernel trees, so when your
resend this series, please add the proper "cc: stable" line to the
signed-off-by area as is documented.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-11 8:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 8:33 [PATCH 0/9] nvmem: patches (set 1) for 5.14 Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 1/9] nvmem: sprd: Add missing MODULE_DEVICE_TABLE Srinivas Kandagatla
2021-06-11 8:55 ` Greg KH
2021-06-11 9:09 ` Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 2/9] nvmem: qcom-spmi-sdam: add " Srinivas Kandagatla
2021-06-11 8:55 ` Greg KH
2021-06-11 8:33 ` [PATCH 3/9] nvmem: sc27xx: Add " Srinivas Kandagatla
2021-06-11 8:55 ` Greg KH
2021-06-11 8:33 ` [PATCH 4/9] nvmem: sprd: Fix an error message Srinivas Kandagatla
2021-06-11 8:56 ` Greg KH
2021-06-11 9:05 ` Srinivas Kandagatla
2021-06-11 9:17 ` Greg KH
2021-06-11 9:45 ` Greg KH
2021-06-11 9:48 ` Greg KH
2021-06-11 10:17 ` Srinivas Kandagatla
2021-06-11 10:09 ` Srinivas Kandagatla
2021-06-11 10:10 ` Marion & Christophe JAILLET
2021-06-11 10:17 ` Greg KH
2021-06-11 10:20 ` Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 5/9] nvmem: core: add a missing of_node_put Srinivas Kandagatla
2021-06-11 8:57 ` Greg KH [this message]
2021-06-11 9:10 ` Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 6/9] nvmem: sunxi_sid: Set type to OTP Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 7/9] nvmem: qfprom: minor nit fixes Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 8/9] nvmem: core: constify nvmem_cell_read_variable_common() return value Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 9/9] nvmem: qfprom: Improve the comment about regulator setting Srinivas Kandagatla
2021-06-11 8:58 ` [PATCH 0/9] nvmem: patches (set 1) for 5.14 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMMlalfdeIW4W1RC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.