Re: [PATCH ethtool v3 3/4] ethtool: Rename QSFP-DD identifiers to use CMIS

From: Ido Schimmel <idosch@idosch.org>
To: Moshe Shemesh <moshe@nvidia.com>
Cc: Michal Kubecek <mkubecek@suse.cz>, Andrew Lunn <andrew@lunn.ch>,
	Jakub Kicinski <kuba@kernel.org>,
	Don Bollinger <don@thebollingers.org>,
	netdev@vger.kernel.org,
	Vladyslav Tarasiuk <vladyslavt@nvidia.com>
Subject: Re: [PATCH ethtool v3 3/4] ethtool: Rename QSFP-DD identifiers to use CMIS
Date: Sun, 13 Jun 2021 17:20:19 +0300	[thread overview]
Message-ID: <YMYUI164vtDYCOhP@shredder> (raw)
In-Reply-To: <1623148348-2033898-4-git-send-email-moshe@nvidia.com>

On Tue, Jun 08, 2021 at 01:32:27PM +0300, Moshe Shemesh wrote:
> +void cmis_show_all(const struct ethtool_module_eeprom *page_zero,
> +		   const struct ethtool_module_eeprom *page_one)
> +{
> +	const __u8 *page_zero_data = page_zero->data;
> +
> +	cmis_show_identifier(page_zero_data);
> +	cmis_show_power_info(page_zero_data);
> +	cmis_show_connector(page_zero_data);
> +	cmis_show_cbl_asm_len(page_zero_data);
> +	cmis_show_sig_integrity(page_zero_data);
> +	cmis_show_mit_compliance(page_zero_data);
> +	cmis_show_mod_lvl_monitors(page_zero_data);
> +
> +	if (page_one)
> +		cmis_show_link_len_from_page(page_one->data - 0x80);
> +
> +	cmis_show_vendor_info(page_zero_data);
> +	cmis_show_rev_compliance(page_zero_data);
> +}
> diff --git a/cmis.h b/cmis.h
> new file mode 100644
> index 0000000..5b7ac38
> --- /dev/null
> +++ b/cmis.h
> @@ -0,0 +1,128 @@

[...]

> +void cmis4_show_all(const struct ethtool_module_eeprom *page_zero,
> +		    const struct ethtool_module_eeprom *page_one);

Should be cmis_show_all():

netlink/module-eeprom.c:335:17: warning: implicit declaration of function ‘cmis_show_all’; did you mean ‘cmis4_show_all’? [-Wimplicit-function-declaration]
  335 |                 cmis_show_all(page_zero, page_one);
      |                 ^~~~~~~~~~~~~
      |                 cmis4_show_all