From: Petr Mladek <pmladek@suse.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Punit Agrawal <punitagrawal@gmail.com>,
senozhatsky@chromium.org, rostedt@goodmis.org,
john.ogness@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition
Date: Wed, 16 Jun 2021 08:56:01 +0200 [thread overview]
Message-ID: <YMmggRL/htxFK2VY@alley> (raw)
In-Reply-To: <8c16059d-6e58-a3e4-25ef-7e2bcabecd86@rasmusvillemoes.dk>
On Tue 2021-06-15 08:50:45, Rasmus Villemoes wrote:
> On 15/06/2021 01.56, Punit Agrawal wrote:
> > Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while
> > improving readability by removing vprintk indirection, inadvertently
> > placed the EXPORT_SYMBOL() for the newly renamed function at the end
> > of the file.
> >
> > For reader sanity, and as is convention move the EXPORT_SYMBOL()
> > declaration just after the end of the function.
> >
> > Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk")
> > Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
> > --
> > Hi,
> >
> > The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while
> > attempting to rebase the RT patches onto newer kernels.
> >
> > Generally I avoid sending trivial changes on their own but this one is
> > a little hard to overlook. Also it felt like an obvious oversight in
> > the original patch.
>
> Yes, indeed, sorry about that, and thanks for fixing it.
Yes, great catch.
> > Please consider merging.
>
> Petr, as this is causing trouble for the -rt patchset, please consider
> if this could make it to Linus before v5.13 release.
Sure, I could do so. But could you please provide some more details
what exact problems it causes?
It looks like a cosmetic issue to me. It would be the only change
in the pull request. I would like to provide some reasonable
justification for it at this stage (for rc7).
Best Regards,
Petr
next prev parent reply other threads:[~2021-06-16 6:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 23:56 [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition Punit Agrawal
2021-06-15 6:50 ` Rasmus Villemoes
2021-06-15 13:36 ` Punit Agrawal
2021-06-16 6:56 ` Petr Mladek [this message]
2021-06-16 7:21 ` Petr Mladek
2021-06-16 7:51 ` John Ogness
2021-06-16 9:15 ` Petr Mladek
2021-06-16 13:52 ` Punit Agrawal
2021-06-16 1:30 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMmggRL/htxFK2VY@alley \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=punitagrawal@gmail.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.