From: Klaus Jensen <its@irrelevant.dk>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Keith Busch <kbusch@kernel.org>,
qemu-block@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/2] hw/nvme: namespace parameter for EUI-64
Date: Wed, 16 Jun 2021 12:22:54 +0200 [thread overview]
Message-ID: <YMnQ/udIfw5mLFlr@apples.localdomain> (raw)
In-Reply-To: <20210614201901.17871-1-xypron.glpk@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Jun 14 22:18, Heinrich Schuchardt wrote:
>The EUI-64 field is the only identifier for NVMe namespaces in UEFI device
>paths. Add a new namespace property "eui64", that provides the user the
>option to specify the EUI-64.
>
>v3:
> use 52-54-00-00-00-00-00-00 as starting values for generating
> EUI-64s
>
>Heinrich Schuchardt (2):
> hw/nvme: namespace parameter for EUI-64
> hw/nvme: default for namespace EUI-64
>
> docs/system/nvme.rst | 6 +++++
> hw/core/machine.c | 1 +
> hw/nvme/ctrl.c | 58 ++++++++++++++++++++++++++------------------
> hw/nvme/ns.c | 11 +++++++++
> hw/nvme/nvme.h | 3 +++
> 5 files changed, 56 insertions(+), 23 deletions(-)
>
>--
>2.30.2
>
LGTM.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-16 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 20:18 [PATCH v3 0/2] hw/nvme: namespace parameter for EUI-64 Heinrich Schuchardt
2021-06-14 20:19 ` [PATCH v3 1/2] " Heinrich Schuchardt
2021-06-14 20:19 ` [PATCH v3 2/2] hw/nvme: default for namespace EUI-64 Heinrich Schuchardt
2021-06-16 10:22 ` Klaus Jensen [this message]
2021-06-28 17:06 ` [PATCH v3 0/2] hw/nvme: namespace parameter for EUI-64 Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMnQ/udIfw5mLFlr@apples.localdomain \
--to=its@irrelevant.dk \
--cc=ehabkost@redhat.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.