From: Greg KH <gregkh@linuxfoundation.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Hao Wu <hao.wu@rubrik.com>,
shrihari.kalkar@rubrik.com, seungyeop.han@rubrik.com,
anish.jhaveri@rubrik.com, peterhuewe@gmx.de, jgg@ziepe.ca,
linux-integrity@vger.kernel.org, pmenzel@molgen.mpg.de,
kgold@linux.ibm.com, zohar@linux.vnet.ibm.com,
why2jjj.linux@gmail.com, hamza@hpe.com, arnd@arndb.de,
nayna@linux.vnet.ibm.com, James.Bottomley@hansenpartnership.com
Subject: Re: [PATCH] tpm: fix ATMEL TPM crash caused by too frequent queries
Date: Fri, 2 Jul 2021 09:12:35 +0200 [thread overview]
Message-ID: <YN68Y1t1eokIg7o1@kroah.com> (raw)
In-Reply-To: <20210702063555.q2phirfv7wxc6axu@kernel.org>
On Fri, Jul 02, 2021 at 09:35:55AM +0300, Jarkko Sakkinen wrote:
> On Tue, Jun 29, 2021 at 09:22:05PM -0700, Hao Wu wrote:
> > This is a fix for the ATMEL TPM crash bug reported in
> > https://patchwork.kernel.org/project/linux-integrity/patch/20200926223150.109645-1-hao.wu@rubrik.com/
> >
> > According to the discussions in the original thread,
> > we don't want to revert the timeout of wait_for_tpm_stat
> > for non-ATMEL chips, which brings back the performance cost.
> > For investigation and analysis of why wait_for_tpm_stat
> > caused the issue, and how the regression was introduced,
> > please read the original thread above.
> >
> > Thus the proposed fix here is to only revert the timeout
> > for ATMEL chips by checking the vendor ID.
> >
> > Signed-off-by: Hao Wu <hao.wu@rubrik.com>
> > Fixes: 9f3fc7bcddcb ("tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers")
>
> Fixes tag should be before SOB.
Does not matter :)
next prev parent reply other threads:[~2021-07-02 7:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 23:18 [PATCH] Fix Atmel TPM crash caused by too frequent queries Hao Wu
2021-06-23 13:35 ` Jarkko Sakkinen
2021-06-24 5:49 ` Hao Wu
2021-06-29 20:06 ` Jarkko Sakkinen
2021-06-30 4:27 ` Hao Wu
2021-06-24 5:33 ` Hao Wu
2021-06-29 20:07 ` Jarkko Sakkinen
2021-06-30 4:22 ` [PATCH] tpm: fix ATMEL " Hao Wu
2021-07-02 6:35 ` Jarkko Sakkinen
2021-07-02 7:12 ` Greg KH [this message]
2021-07-02 7:33 ` Hao Wu
2021-07-02 7:35 ` Hao Wu
2021-07-02 7:45 ` Jarkko Sakkinen
2021-07-02 7:59 ` Hao Wu
2021-07-02 8:42 ` Jarkko Sakkinen
2021-07-02 11:57 ` Jarkko Sakkinen
2021-07-02 19:16 ` Hao Wu
2021-07-05 5:19 ` Jarkko Sakkinen
2021-07-05 5:29 ` Hao Wu
2021-07-04 0:07 ` Hao Wu
2021-07-05 7:15 ` Jarkko Sakkinen
2021-07-05 23:09 ` Hao Wu
2021-07-06 12:34 ` Mimi Zohar
2021-07-07 4:18 ` Hao Wu
2021-07-07 4:34 ` Hao Wu
2021-07-07 4:31 ` [PATCH v2] " Hao Wu
2021-07-07 9:24 ` Jarkko Sakkinen
2021-07-07 18:28 ` Hao Wu
2021-07-07 21:10 ` Jarkko Sakkinen
2021-07-09 4:43 ` Hao Wu
2021-07-09 4:40 ` [PATCH v2] tpm: fix Atmel " Hao Wu
2021-07-09 17:47 ` Jarkko Sakkinen
2021-07-09 19:23 ` Hao Wu
2021-07-11 7:37 ` Hao Wu
2021-07-16 5:30 ` Hao Wu
2021-07-11 7:51 ` [PATCH v3] " Hao Wu
2021-07-27 2:46 ` Jarkko Sakkinen
2021-07-27 3:40 ` Hao Wu
2021-08-14 22:25 ` [PATCH v4] " Hao Wu
2021-08-26 5:38 ` Hao Wu
2021-08-26 16:24 ` Jarkko Sakkinen
2021-08-27 0:35 ` Hao Wu
2021-09-04 21:14 ` Hao Wu
2021-09-04 23:15 ` Hao Wu
2021-09-05 3:51 ` [PATCH v5] " Hao Wu
2021-09-07 17:43 ` Jarkko Sakkinen
2021-09-08 8:33 ` Hao Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN68Y1t1eokIg7o1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=anish.jhaveri@rubrik.com \
--cc=arnd@arndb.de \
--cc=hamza@hpe.com \
--cc=hao.wu@rubrik.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kgold@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=seungyeop.han@rubrik.com \
--cc=shrihari.kalkar@rubrik.com \
--cc=why2jjj.linux@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.