Re: [PATCH v3 11/13] soc: qcom: aoss: Drop power domain support

From: Matthias Kaehlcke <mka@chromium.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org,
	swboyd@chromium.org, ulf.hansson@linaro.org, rjw@rjwysocki.net,
	agross@kernel.org, ohad@wizery.com, mathieu.poirier@linaro.org,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dianders@chromium.org, rishabhb@codeaurora.org,
	sidgup@codeaurora.org
Subject: Re: [PATCH v3 11/13] soc: qcom: aoss: Drop power domain support
Date: Fri, 25 Jun 2021 15:01:27 -0700	[thread overview]
Message-ID: <YNZSN2wXomiZHsz4@google.com> (raw)
In-Reply-To: <1624560727-6870-12-git-send-email-sibis@codeaurora.org>

On Fri, Jun 25, 2021 at 12:22:05AM +0530, Sibi Sankar wrote:
> The load state resources are expected to follow the life cycle of the
> remote processor it tracks. However, modeling load state resources as
> power-domains result in them getting turned off during system suspend
> and thereby falling out of sync with the remote processors that are still
> on. Fix this by replacing load state resource control through the generic
> qmp message send interface instead.

nit: the above sounds as if this patch does all of that, when it only
removes power domain support. Instead you could start with saying what
the patch actually does (remove power domain support), followed by why
PD support isn't needed anymore (now done by sending QMP messages directly).

> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
>  drivers/soc/qcom/qcom_aoss.c | 109 ++-----------------------------------------
>  1 file changed, 3 insertions(+), 106 deletions(-)
> 
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> index 998ee7605eb2..f0c3726e8c46 100644
> --- a/drivers/soc/qcom/qcom_aoss.c
> +++ b/drivers/soc/qcom/qcom_aoss.c
>
> ...
>
> @@ -650,13 +550,11 @@ static int qmp_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_close_qmp;
>  
> -	ret = qmp_pd_add(qmp);
> -	if (ret)
> -		goto err_remove_qdss_clk;
> -
>  	ret = qmp_cooling_devices_register(qmp);
> -	if (ret)
> +	if (ret) {
>  		dev_err(&pdev->dev, "failed to register aoss cooling devices\n");
> +		goto err_remove_qdss_clk;

This isn't really related with the PD removal, right? I wonder if it was
intentional to have _probe() succeed even when the cooling device
registration failed, since the cooling devices aren't essential.

If it is still desirable to fail the change should be done in a separate
patch, unless it is actually related with removing PD support.