Re: [PATCH] nds32: fix up stack guard gap - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Qiang Liu <cyruscyliu@gmail.com>
Cc: Hugh Dickins <hughd@google.com>, Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	iLifetruth <yixiaonn@gmail.com>, Michal Hocko <mhocko@suse.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH] nds32: fix up stack guard gap
Date: Wed, 30 Jun 2021 11:05:15 +0200	[thread overview]
Message-ID: <YNwzyyx+8N6lus+y@kroah.com> (raw)
In-Reply-To: <CAAKa2jn6LB14BYXJWoVoqgcqrjTYwJgLdDCa8mir=jOw6x5ZDA@mail.gmail.com>

On Wed, Jun 30, 2021 at 10:33:29AM +0800, Qiang Liu wrote:
> Hi,
> 
> On Wed, Jun 30, 2021 at 4:33 AM Hugh Dickins <hughd@google.com> wrote:
> >
> > On Tue, 29 Jun 2021, Greg Kroah-Hartman wrote:
> >
> > > Commit 1be7107fbe18 ("mm: larger stack guard gap, between vmas") fixed
> > > up almost all architectures to deal with the stack guard gap, but forgit
> > > nds32.
> > >
> > > Resolve this by properly fixing up the nsd32's version of
> > > arch_get_unmapped_area()
> > >
> > > Reported-by: iLifetruth <yixiaonn@gmail.com>
> > > Cc: Nick Hu <nickhu@andestech.com>
> > > Cc: Greentime Hu <green.hu@gmail.com>
> > > Cc: Vincent Chen <deanbo422@gmail.com>
> > > Cc: Michal Hocko <mhocko@suse.com>
> > > Cc: Hugh Dickins <hughd@google.com>
> > > Cc: Qiang Liu <cyruscyliu@gmail.com>
> > > Cc: stable <stable@vger.kernel.org>
> > > Fixes: 1be7107fbe18 ("mm: larger stack guard gap, between vmas")
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Acked-by: Hugh Dickins <hughd@google.com>
> >
> > but it's a bit unfair to say that commit forgot nds32:
> > nds32 came into the tree nearly a year later.
> Could we use "not forward ported to"?

Nah, it was just a mistake in the nds32 implementation when it was
submitted.

thanks,

greg k-h