From: Tejun Heo <tj@kernel.org>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Huaixin Chang <changhuaixin@linux.alibaba.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
anderson@cs.unc.edu, baruah@wustl.edu, bsegall@google.com,
dietmar.eggemann@arm.com, dtcccc@linux.alibaba.com,
juri.lelli@redhat.com, khlebnikov@yandex-team.ru,
luca.abeni@santannapisa.it, mgorman@suse.de, mingo@redhat.com,
odin@uged.al, odin@ugedal.com, pauld@redhead.com, pjt@google.com,
rostedt@goodmis.org, shanpeic@linux.alibaba.com,
tommaso.cucinotta@santannapisa.it, vincent.guittot@linaro.org,
xiyou.wangcong@gmail.com
Subject: Re: [PATCH 1/2] sched/fair: Add cfs bandwidth burst statistics
Date: Mon, 23 Aug 2021 09:03:00 -1000 [thread overview]
Message-ID: <YSPw5B0Njj3sUdKB@slm.duckdns.org> (raw)
In-Reply-To: <20210823183210.bih6p77fh3gwdfic@oracle.com>
On Mon, Aug 23, 2021 at 02:32:10PM -0400, Daniel Jordan wrote:
> burst_time is nsec, not usec.
>
> Just "burst_time" seems the way to go for consistency with
> throttled_time in the same file, though "burst_usec" nicely has units
> and would have the same name between cgroup1 and 2.
The cgroup2 interface rule is that time units are in usecs. The right thing
to do is keeping the _usec postfix (to avoid confusion due to the unit
change from cgroup1) and converting it to usecs for printing.
Thanks.
--
tejun
next prev parent reply other threads:[~2021-08-23 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 7:08 [PATCH 0/2] Add statistics and document for cfs bandwidth burst Huaixin Chang
2021-08-16 7:08 ` [PATCH 1/2] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2021-08-23 18:32 ` Daniel Jordan
2021-08-23 19:03 ` Tejun Heo [this message]
2021-08-16 7:08 ` [PATCH 2/2] sched/fair: Add document for burstable CFS bandwidth Huaixin Chang
2021-08-23 20:53 ` Daniel Jordan
-- strict thread matches above, loose matches on Subject: below --
2021-08-30 3:22 [PATCH 0/2 v2] Add statistics and document for cfs_b burst Huaixin Chang
2021-08-30 3:22 ` [PATCH 1/2] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2021-09-03 18:47 ` Benjamin Segall
2021-07-30 7:09 [PATCH 0/2] Add statistics and ducument for cfs bandwidth burst Huaixin Chang
2021-07-30 7:09 ` [PATCH 1/2] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2021-08-12 12:18 ` changhuaixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSPw5B0Njj3sUdKB@slm.duckdns.org \
--to=tj@kernel.org \
--cc=anderson@cs.unc.edu \
--cc=baruah@wustl.edu \
--cc=bsegall@google.com \
--cc=changhuaixin@linux.alibaba.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=dtcccc@linux.alibaba.com \
--cc=juri.lelli@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=odin@uged.al \
--cc=odin@ugedal.com \
--cc=pauld@redhead.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=shanpeic@linux.alibaba.com \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.