From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v2] BTRFS/NFSD: provide more unique inode number for btrfs export
Date: Sat, 28 Aug 2021 08:09:18 +0100 [thread overview]
Message-ID: <YSnhHl0HDOgg07U5@infradead.org> (raw)
In-Reply-To: <163010550851.7591.9342822614202739406@noble.neil.brown.name>
On Sat, Aug 28, 2021 at 09:05:08AM +1000, NeilBrown wrote:
> There doesn't seem to be any other option - and this is still an
> improvement over the current behaviour.
>
> Collisions should still be quite a few years away, and there is hope
> that the btrfs developers will take action before then to provide some
> certainty. Not much hope, but some.
I think that is a very dangerous assumption. Given how every inode
allocation tends to be somewhat predictable I'm also really worried
that this actually opens up an attach vector. Last but not least
I also very much disagree with any of the impact to common code.
Most importantly the kstat structure, which exist to support the stat
family of system calls and not as a side channel for NFS file handles
(nevermind that it is hidden in a nfs patch and didn't even Cc the
fsdevel list), but also all the impact to the generic nfsd code for
this very broken concept. If you want to support such a scheme in
btrfs as the lesser of evils (which I disagree with), please make
sure it stays self-contained in the btrfs specific file handle
encoding and decoding.
next prev parent reply other threads:[~2021-08-28 7:11 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 4:28 [PATCH] NFSD: drop support for ancient file-handles NeilBrown
2021-08-26 6:03 ` [PATCH v2] BTRFS/NFSD: provide more unique inode number for btrfs export NeilBrown
2021-08-26 20:19 ` J. Bruce Fields
2021-08-26 22:10 ` NeilBrown
2021-08-27 14:53 ` Frank Filz
2021-08-27 22:57 ` NeilBrown
2021-08-27 23:46 ` Frank Filz
2021-08-27 23:55 ` NeilBrown
2021-08-28 2:21 ` Frank Filz
2021-08-27 18:32 ` J. Bruce Fields
2021-08-27 23:01 ` NeilBrown
2021-08-27 16:20 ` Christoph Hellwig
2021-08-27 23:05 ` NeilBrown
2021-08-28 7:09 ` Christoph Hellwig [this message]
2021-08-31 4:59 ` NeilBrown
2021-09-01 7:20 ` Christoph Hellwig
2021-09-01 15:22 ` J. Bruce Fields
2021-09-02 4:14 ` NeilBrown
2021-09-05 16:07 ` J. Bruce Fields
2021-09-06 1:29 ` NeilBrown
2021-09-11 14:12 ` Amir Goldstein
2021-09-13 0:43 ` NeilBrown
2021-09-13 10:04 ` Amir Goldstein
2021-09-13 22:59 ` NeilBrown
2021-09-14 5:45 ` Amir Goldstein
2021-09-20 22:09 ` NeilBrown
2021-09-02 7:11 ` Christoph Hellwig
2021-09-02 4:06 ` NeilBrown
2021-09-02 7:16 ` Christoph Hellwig
2021-09-02 7:53 ` Miklos Szeredi
2021-09-02 14:16 ` Frank Filz
2021-09-02 23:02 ` NeilBrown
2021-08-26 14:10 ` [PATCH] NFSD: drop support for ancient file-handles Chuck Lever III
2021-08-26 21:38 ` NeilBrown
2021-08-26 14:51 ` J. Bruce Fields
2021-08-26 21:41 ` NeilBrown
2021-08-27 15:15 ` Christoph Hellwig
2021-08-27 23:24 ` NeilBrown
2021-08-31 4:41 ` [PATCH 1/2 v2] NFSD: drop support for ancient filehandles NeilBrown
2021-08-31 4:42 ` [PATCH 2/2] NFSD: simplify struct nfsfh NeilBrown
2021-09-01 7:44 ` Christoph Hellwig
2021-09-01 7:44 ` [PATCH 1/2 v2] NFSD: drop support for ancient filehandles Christoph Hellwig
2021-09-01 14:21 ` Chuck Lever III
2021-09-02 1:14 ` [PATCH 1/3 v3] NFSD: move filehandle format declarations out of "uapi" NeilBrown
2021-09-02 1:15 ` [PATCH 2/3 v3] NFSD: drop support for ancient filehandles NeilBrown
2021-09-02 1:16 ` [PATCH 3/3 v3] NFSD: simplify struct nfsfh NeilBrown
2021-09-02 7:22 ` [PATCH 2/3 v3] NFSD: drop support for ancient filehandles Christoph Hellwig
2021-09-02 7:21 ` [PATCH 1/3 v3] NFSD: move filehandle format declarations out of "uapi" Christoph Hellwig
2021-09-23 21:21 ` Bruce Fields
2021-09-25 4:21 ` NeilBrown
-- strict thread matches above, loose matches on Subject: below --
2021-07-27 22:37 [PATCH/RFC 00/11] expose btrfs subvols in mount table correctly NeilBrown
2021-08-13 1:45 ` [PATCH] VFS/BTRFS/NFSD: provide more unique inode number for btrfs export NeilBrown
2021-08-15 7:39 ` Goffredo Baroncelli
2021-08-15 19:35 ` Roman Mamedov
2021-08-15 22:17 ` NeilBrown
2021-08-23 4:05 ` [PATCH v2] BTRFS/NFSD: " NeilBrown
2021-08-23 8:17 ` kernel test robot
2021-08-23 8:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSnhHl0HDOgg07U5@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=josef@toxicpanda.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.