Re: [PATCH v4] drm: Improve the output_poll_changed description

From: Daniel Vetter <daniel@ffwll.ch>
To: "ZhiJie.Zhang" <zhangzhijie@loongson.cn>
Cc: daniel@ffwll.ch, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	botton_zhang@163.com
Subject: Re: [PATCH v4] drm: Improve the output_poll_changed description
Date: Fri, 3 Sep 2021 11:31:30 +0200	[thread overview]
Message-ID: <YTHrcvAXxoVgV0/9@phenom.ffwll.local> (raw)
In-Reply-To: <20210903032402.11935-1-zhangzhijie@loongson.cn>

On Fri, Sep 03, 2021 at 11:24:02AM +0800, ZhiJie.Zhang wrote:
> From: zhangzhijie <zhangzhijie@loongson.cn>
> 
> this callback was used by drm_kms_helper_hotplug_event()
> 
> V2: (Thanks for Daniel's suggestions)
> - remove the FIXME below.since with the drm_client
> - infrastructure and the generic fbdev emulation we've
> - resolved this all very neatly now.
> 
> V3: Add comments that This hook is deprecated
> - new implementation methods instead of this hook
> 
> v4: used by drm_kms_helper_hotplug_event()
> - drm_fb_helper_hotplug_changed() is not found
> instead by drm_kms_helper_hotplug_event()
> 
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>

Applied to drm-misc-next, thanks for the patch.
-Daniel

> ---
>  include/drm/drm_mode_config.h | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index 1ddf7783fdf7..48b7de80daf5 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -103,14 +103,13 @@ struct drm_mode_config_funcs {
>  	 * Callback used by helpers to inform the driver of output configuration
>  	 * changes.
>  	 *
> -	 * Drivers implementing fbdev emulation with the helpers can call
> -	 * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
> -	 * helper of output changes.
> +	 * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
> +	 * to call this hook to inform the fbdev helper of output changes.
>  	 *
> -	 * FIXME:
> -	 *
> -	 * Except that there's no vtable for device-level helper callbacks
> -	 * there's no reason this is a core function.
> +	 * This hook is deprecated, drivers should instead use
> +	 * drm_fbdev_generic_setup() which takes care of any necessary
> +	 * hotplug event forwarding already without further involvement by
> +	 * the driver.
>  	 */
>  	void (*output_poll_changed)(struct drm_device *dev);
>  
> -- 
> 2.33.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch