From: Joerg Roedel <joro@8bytes.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-coco@lists.linux.dev, Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v2 1/4] KVM: SVM: Get rid of *ghcb_msr_bits() functions
Date: Thu, 9 Sep 2021 15:32:21 +0200 [thread overview]
Message-ID: <YToM5akzNrlqHTJz@8bytes.org> (raw)
In-Reply-To: <YS/sqmgbS6ACRfSD@google.com>
On Wed, Sep 01, 2021 at 09:12:10PM +0000, Sean Christopherson wrote:
> On Thu, Jul 22, 2021, Joerg Roedel wrote:
> > case GHCB_MSR_TERM_REQ: {
> > u64 reason_set, reason_code;
> >
> > - reason_set = get_ghcb_msr_bits(svm,
> > - GHCB_MSR_TERM_REASON_SET_MASK,
> > - GHCB_MSR_TERM_REASON_SET_POS);
> > - reason_code = get_ghcb_msr_bits(svm,
> > - GHCB_MSR_TERM_REASON_MASK,
> > - GHCB_MSR_TERM_REASON_POS);
> > + reason_set = GHCB_MSR_TERM_REASON_SET(control->ghcb_gpa);
> > + reason_code = GHCB_MSR_TERM_REASON(control->ghcb_gpa);
> > +
> > pr_info("SEV-ES guest requested termination: %#llx:%#llx\n",
> > reason_set, reason_code);
> > +
> > fallthrough;
>
> Not related to this patch, but why use fallthrough and more importantly, why is
> this an -EINVAL return? Why wouldn't KVM forward the request to userspace instead
> of returning an opaque -EINVAL?
I guess it is to signal an error condition up the call-chain to get the
guest terminated, like requested.
Regards,
Joerg
next prev parent reply other threads:[~2021-09-09 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 11:52 [PATCH v2 0/4] KVM: SVM: Add initial GHCB protocol version 2 support Joerg Roedel
2021-07-22 11:52 ` [PATCH v2 1/4] KVM: SVM: Get rid of *ghcb_msr_bits() functions Joerg Roedel
2021-09-01 21:12 ` Sean Christopherson
2021-09-01 21:31 ` Sean Christopherson
2021-09-09 13:22 ` Joerg Roedel
2021-09-09 13:32 ` Joerg Roedel [this message]
2021-09-20 16:10 ` Sean Christopherson
2021-07-22 11:52 ` [PATCH v2 2/4] KVM: SVM: Add support to handle AP reset MSR protocol Joerg Roedel
2021-09-01 21:45 ` Sean Christopherson
2021-07-22 11:52 ` [PATCH v2 3/4] KVM: SVM: Add support for Hypervisor Feature support " Joerg Roedel
2021-07-22 12:01 ` [PATCH v2.1 " Joerg Roedel
2021-09-01 22:41 ` Sean Christopherson
2021-07-22 11:52 ` [PATCH v2 4/4] KVM: SVM: Increase supported GHCB protocol version Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YToM5akzNrlqHTJz@8bytes.org \
--to=joro@8bytes.org \
--cc=brijesh.singh@amd.com \
--cc=jmattson@google.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.