From: Taylor Blau <me@ttaylorr.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 0/2] reroll for cb/plug-leaks-in-alloca-emu-users
Date: Thu, 16 Sep 2021 12:53:43 -0400 [thread overview]
Message-ID: <YUN2lwA3w8zAoYhS@nand.local> (raw)
In-Reply-To: <20210916085523.68581-1-carenas@gmail.com>
On Thu, Sep 16, 2021 at 01:55:21AM -0700, Carlo Marcelo Arenas Belón wrote:
> v2 includes all suggestions and feedback, and tries probably too hard
> to modify the last test in a way that wouldn't require long lines.
Thanks, this version looks good to me. I suspect the "tries probably too
hard" is referring to putting the sed expressions into a file and then
loading them from that file with `-f`.
I wouldn't mind the long line, or splitting it across multiple lines
with `\`. But what you wrote is fine, too.
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Thanks,
Taylor
BTW: no need to put "reroll for" in the subject line for this series.
The [PATCH v2] indicates that it is a reroll.
prev parent reply other threads:[~2021-09-16 18:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 2:37 [PATCH 0/2] t0000: truly leak free Carlo Marcelo Arenas Belón
2021-09-16 2:37 ` [PATCH 1/2] tree-diff: fix leak when not HAVE_ALLOCA Carlo Marcelo Arenas Belón
2021-09-16 5:17 ` Taylor Blau
2021-09-16 5:27 ` Junio C Hamano
2021-09-16 2:37 ` [PATCH 2/2] t0000: avoid masking git exit value through pipes Carlo Marcelo Arenas Belón
2021-09-16 5:21 ` Taylor Blau
2021-09-16 6:23 ` Junio C Hamano
2021-09-16 16:49 ` Taylor Blau
2021-09-16 5:29 ` Junio C Hamano
2021-09-16 10:45 ` Ævar Arnfjörð Bjarmason
2021-09-16 8:55 ` [PATCH v2 0/2] reroll for cb/plug-leaks-in-alloca-emu-users Carlo Marcelo Arenas Belón
2021-09-16 8:55 ` [PATCH v2 1/2] tree-diff: fix leak when not HAVE_ALLOCA_H Carlo Marcelo Arenas Belón
2021-09-16 15:00 ` Jeff King
2021-09-16 8:55 ` [PATCH v2 2/2] t0000: avoid masking git exit value through pipes Carlo Marcelo Arenas Belón
2021-09-16 16:53 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUN2lwA3w8zAoYhS@nand.local \
--to=me@ttaylorr.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.