From: Salvatore Bonaccorso <carnil@debian.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency"
Date: Sat, 18 Sep 2021 14:32:40 +0200 [thread overview]
Message-ID: <YUXcaBR3Yh4PqMxN@eldamar.lan> (raw)
In-Reply-To: <20170418023639.GE4152decadent!org!uk>
Hi Greg,
This is a reply to a very old patch submission:
On Tue, Apr 18, 2017 at 02:36:39AM +0000, Ben Hutchings wrote:
>
> This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
> USB_LED_TRIG. This config symbol has bool type and enables extra code
> in usb_common itself, not a separate driver. Enabling it should not
> force usb_common to be built-in!
>
> Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/usb/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index fbe493d44e81..8270abe6c677 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -154,8 +154,7 @@ source "drivers/usb/gadget/Kconfig"
> =20
> config USB_LED_TRIG
> bool "USB LED Triggers"
> - depends on LEDS_CLASS && LEDS_TRIGGERS
> - select USB_COMMON
> + depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
> help
> This option adds LED triggers for USB host and/or gadget activity.
Was going through the series of patches we had applied in Debian and
noticed while this was submitted by Ben back in 2017, it looks it was
never applied or considered. Would that be something you could pick
up? I'm inlining the original patch from Ben.
Regards,
Salvatore
From: Ben Hutchings <ben@decadent.org.uk>
Date: Wed, 11 Jan 2017 04:30:40 +0000
Subject: Partially revert "usb: Kconfig: using select for USB_COMMON dependency"
This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
USB_LED_TRIG. This config symbol has bool type and enables extra code
in usb_common itself, not a separate driver. Enabling it should not
force usb_common to be built-in!
Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/usb/common/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig
index d611477aae41..196f4a397587 100644
--- a/drivers/usb/common/Kconfig
+++ b/drivers/usb/common/Kconfig
@@ -6,8 +6,7 @@ config USB_COMMON
config USB_LED_TRIG
bool "USB LED Triggers"
- depends on LEDS_CLASS && LEDS_TRIGGERS
- select USB_COMMON
+ depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
help
This option adds LED triggers for USB host and/or gadget activity.
next parent reply other threads:[~2021-09-18 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170418023639.GE4152decadent!org!uk>
2021-09-18 12:32 ` Salvatore Bonaccorso [this message]
2021-09-18 12:41 ` [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency" Greg Kroah-Hartman
2021-09-18 12:56 ` Salvatore Bonaccorso
2021-09-21 14:23 ` Greg Kroah-Hartman
2021-09-21 14:36 ` Salvatore Bonaccorso
2021-09-21 14:34 Salvatore Bonaccorso
2021-09-29 20:28 ` Salvatore Bonaccorso
2021-10-05 11:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUXcaBR3Yh4PqMxN@eldamar.lan \
--to=carnil@debian.org \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.