From: Matthew Wilcox <willy@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] pgflags_t
Date: Thu, 7 Oct 2021 15:48:28 +0100 [thread overview]
Message-ID: <YV8IvJ9HZI0+o243@casper.infradead.org> (raw)
In-Reply-To: <a8cdcb3c-26e5-33b5-44f9-459df8a40dbb@suse.cz>
On Thu, Oct 07, 2021 at 04:37:08PM +0200, Vlastimil Babka wrote:
> > - pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags, &head->flags,
> > + pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags.f, &head->flags.f,
>
> The %pGp case (here and elsewhere) could perhaps take the new type, no?
> Would need to change format_page_flags() and flags_string() in lib/vsprintf.c
Oh, good point. I don't think format_page_flags() would _need_ to
change, but we might _want_ to change it. Particularly if we go with Al
Viro's suggestion of using __bitwise to create a new type that's checked
with sparse.
prev parent reply other threads:[~2021-10-07 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 14:58 [RFC] pgflags_t Matthew Wilcox
2021-10-06 15:16 ` David Hildenbrand
2021-10-06 15:29 ` Matthew Wilcox
2021-10-06 15:22 ` Al Viro
2021-10-06 15:23 ` David Hildenbrand
2021-10-06 15:28 ` Al Viro
2021-10-06 15:32 ` David Hildenbrand
2021-10-06 15:46 ` Al Viro
2021-10-06 15:47 ` David Hildenbrand
2021-10-06 15:38 ` Matthew Wilcox
2021-10-06 15:48 ` Al Viro
2021-10-07 14:37 ` Vlastimil Babka
2021-10-07 14:48 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV8IvJ9HZI0+o243@casper.infradead.org \
--to=willy@infradead.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.