Re: [PATCH 0/2] Introduce simple pidfd to task helper

From: Matthew Bobrowski <repnop@google.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Vlastimil Babka <vbabka@suse.cz>,
	Suren Baghdasaryan <surenb@google.com>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 0/2] Introduce simple pidfd to task helper
Date: Thu, 7 Oct 2021 22:12:57 +0000	[thread overview]
Message-ID: <YV9w6QQcGlgYWjfd@google.com> (raw)
In-Reply-To: <20211004125050.1153693-1-christian.brauner@ubuntu.com>

On Mon, Oct 04, 2021 at 02:50:48PM +0200, Christian Brauner wrote:
> Hey everyone,
> 
> This adds a simple helper to get rid of some code duplication introduced
> with the addition of two new pidfd-based syscalls in mm. We should've
> probably added the helper right away and I think I mentioned this during
> in the review on one of the revisions but we probably just lost track of
> it. If this looks ok to you, I'll queue this up for next.

I went through the series. Seems like a very sensible thing to do, so thanks for
adding the helper and updating the call sites accordingly.

Reviewed-by: Matthew Bobrowski <repnop@google.com>

> Christian Brauner (2):
>   pid: add pidfd_get_task() helper
>   mm: use pidfd_get_task()
> 
>  include/linux/pid.h |  1 +
>  kernel/pid.c        | 34 ++++++++++++++++++++++++++++++++++
>  mm/madvise.c        | 15 +++------------
>  mm/oom_kill.c       | 15 +++------------
>  4 files changed, 41 insertions(+), 24 deletions(-)
> 
> 
> base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896
> -- 
> 2.30.2
> 
/M