All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	Damien Le Moal <Damien.LeMoal@wdc.com>,
	Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
Subject: Re: [PATCH 1/5] zbd: Remove cast to unsigned long long for printf
Date: Wed, 13 Oct 2021 08:27:11 +0000	[thread overview]
Message-ID: <YWaYXjMLrTf7b2bc@x1-carbon> (raw)
In-Reply-To: <20211013060903.166543-2-shinichiro.kawasaki@wdc.com>

On Wed, Oct 13, 2021 at 03:08:59PM +0900, Shin'ichiro Kawasaki wrote:
> Many of the variables in zbd.c have type uint64_t. They are casted to
> unsigned long long and printed with printf %llu format to handle
> uint64_t types difference among architectures. This requires many
> lengthy casts to unsigned long long.
> 
> To simplify the code, remove the casts to unsigned long long. Some of
> the casts are simply unnecessary. To remove other casts, replace the
> printf format %llu with PRIu64 so that uint64_t type difference among
> architectures is handled accordingly.
> 
> Fio build pass of this change was confirmed with 32bit ARM cross
> compiler and 64bit x86 compiler.
> 
> Suggested-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---

Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>

  reply	other threads:[~2021-10-13  8:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  6:08 [PATCH 0/5] zbd: Fix failures unique to specific zoned devices Shin'ichiro Kawasaki
2021-10-13  6:08 ` [PATCH 1/5] zbd: Remove cast to unsigned long long for printf Shin'ichiro Kawasaki
2021-10-13  8:27   ` Niklas Cassel [this message]
2021-10-13  6:09 ` [PATCH 2/5] zbd: Fix type of local variable min_bs Shin'ichiro Kawasaki
2021-10-13  8:27   ` Niklas Cassel
2021-10-13  6:09 ` [PATCH 3/5] t/zbd: Do not use too large block size in test case #4 Shin'ichiro Kawasaki
2021-10-13  8:27   ` Niklas Cassel
2021-10-13  6:09 ` [PATCH 4/5] t/zbd: Align block size to zone capacity Shin'ichiro Kawasaki
2021-10-13  8:27   ` Niklas Cassel
2021-10-13  6:09 ` [PATCH 5/5] t/zbd: Add -w option to ensure no open zone before write tests Shin'ichiro Kawasaki
2021-10-13  8:28   ` Niklas Cassel
2021-10-17 13:00 ` [PATCH 0/5] zbd: Fix failures unique to specific zoned devices Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWaYXjMLrTf7b2bc@x1-carbon \
    --to=niklas.cassel@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=Dmitry.Fomichev@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.