Re: [RFC 2/9] bpf: various constants

From: Greg KH <gregkh@linuxfoundation.org>
To: Lorenz Bauer <lmb@cloudflare.com>
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	bpf@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: [RFC 2/9] bpf: various constants
Date: Thu, 14 Oct 2021 16:43:41 +0200	[thread overview]
Message-ID: <YWhCHbCw17fxQtIN@kroah.com> (raw)
In-Reply-To: <20211014143436.54470-3-lmb@cloudflare.com>

On Thu, Oct 14, 2021 at 03:34:26PM +0100, Lorenz Bauer wrote:
> ---
>  include/uapi/linux/bpf.h | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)

I know I don't take matches without any changelog text, maybe other
maintainers are more lax?

Also, no signed-off-by:?

:(

> 
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 78b532d28761..211b9d902006 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1248,7 +1248,10 @@ enum bpf_stack_build_id_status {
>  	BPF_STACK_BUILD_ID_IP = 2,
>  };
>  
> -#define BPF_BUILD_ID_SIZE 20
> +enum {
> +	BPF_BUILD_ID_SIZE = 20,
> +};
> +
>  struct bpf_stack_build_id {
>  	__s32		status;
>  	unsigned char	build_id[BPF_BUILD_ID_SIZE];
> @@ -1258,7 +1261,9 @@ struct bpf_stack_build_id {
>  	};
>  };
>  
> -#define BPF_OBJ_NAME_LEN 16U
> +enum {
> +	BPF_OBJ_NAME_LEN = 16U,
> +};
>  
>  union bpf_attr {
>  	struct { /* anonymous struct used by BPF_MAP_CREATE command */
> @@ -5464,7 +5469,9 @@ struct bpf_xdp_sock {
>  	__u32 queue_id;
>  };
>  
> -#define XDP_PACKET_HEADROOM 256
> +enum {
> +	XDP_PACKET_HEADROOM = 256,
> +};
>  
>  /* User return codes for XDP prog type.
>   * A valid XDP program must return one of these defined values. All other
> @@ -5582,7 +5589,9 @@ struct sk_reuseport_md {
>  	__bpf_md_ptr(struct bpf_sock *, migrating_sk);
>  };
>  
> -#define BPF_TAG_SIZE	8
> +enum {
> +	BPF_TAG_SIZE = 8,
> +};
>  
>  struct bpf_prog_info {
>  	__u32 type;
> -- 
> 2.30.2
> 