From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] for-each-ref: delay parsing of --sort=<atom> options
Date: Thu, 21 Oct 2021 10:54:33 -0400 [thread overview]
Message-ID: <YXF/KTD7NgTAPw6G@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqpmrzo00q.fsf@gitster.g>
On Wed, Oct 20, 2021 at 02:32:21PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Yeah, I faced something similar with 7c5045fc18 (ref-filter: apply
> > fallback refname sort only after all user sorts, 2020-05-03). I suspect
> > you could use the same keys as those tests, though I am OK if we simply
> > leave it as a quietly-fixed bug.
>
> Ah, I guess I can cheat and add a new test after these.
>
> If --no-sort weren't taking effect, the expected outcome would be
> the asme as the previous step this copied from, but with --no-sort
> clearing the sort keys, we sort by taggerdate and then tiebreak with
> the refname, and taggeremail does not get into the picture (other
> than being repeated at the end of the refname).
Yeah, I think what you have here makes sense. It's too bad we can't run
it on the "before" state to double-check that we are triggering the old
breakage, but there is simply no "--no-sort" at all before your patch
(which is good, because it would have been broken ;) ).
-Peff
prev parent reply other threads:[~2021-10-21 14:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 18:32 [PATCH] for-each-ref: delay parsing of --sort=<atom> options Junio C Hamano
2021-10-19 22:18 ` Jeff King
2021-10-20 2:20 ` Jeff King
2021-10-20 12:30 ` Ævar Arnfjörð Bjarmason
2021-10-20 13:24 ` [RFC PATCH v2 0/4] for-each-ref: delay parsing of --sort=<atom> options + linux-leaks fixes Ævar Arnfjörð Bjarmason
2021-10-20 13:24 ` [RFC PATCH v2 1/4] tag: use a "goto cleanup" pattern, leak less memory Ævar Arnfjörð Bjarmason
2021-10-20 14:37 ` Junio C Hamano
2021-10-20 13:24 ` [RFC PATCH v2 2/4] ref-filter API user: add and use a ref_sorting_release() Ævar Arnfjörð Bjarmason
2021-10-20 14:39 ` Junio C Hamano
2021-10-20 13:24 ` [RFC PATCH v2 3/4] for-each-ref: delay parsing of --sort=<atom> options Ævar Arnfjörð Bjarmason
2021-10-20 13:24 ` [RFC PATCH v2 4/4] branch: use ref_sorting_release() Ævar Arnfjörð Bjarmason
2021-10-20 14:43 ` [RFC PATCH v2 0/4] for-each-ref: delay parsing of --sort=<atom> options + linux-leaks fixes Junio C Hamano
2021-10-20 18:27 ` [PATCH 0/3] ref-filter: add a ref_sorting_release() Ævar Arnfjörð Bjarmason
2021-10-20 18:27 ` [PATCH 1/3] tag: use a "goto cleanup" pattern, leak less memory Ævar Arnfjörð Bjarmason
2021-10-20 18:27 ` [PATCH 2/3] ref-filter API user: add and use a ref_sorting_release() Ævar Arnfjörð Bjarmason
2021-10-20 18:27 ` [PATCH 3/3] branch: use ref_sorting_release() Ævar Arnfjörð Bjarmason
2021-10-20 13:58 ` [PATCH] for-each-ref: delay parsing of --sort=<atom> options Junio C Hamano
2021-10-20 20:48 ` Jeff King
2021-10-20 21:32 ` Junio C Hamano
2021-10-21 14:54 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXF/KTD7NgTAPw6G@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.