From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] Balance vs device add fixes
Date: Tue, 2 Nov 2021 09:12:16 -0400 [thread overview]
Message-ID: <YYE5MB31cKGy0KD1@localhost.localdomain> (raw)
In-Reply-To: <3447a87c-d91f-1c24-a77f-9a87d946bab4@oracle.com>
On Tue, Nov 02, 2021 at 12:52:11PM +0800, Anand Jain wrote:
> On 01/11/2021 19:53, Nikolay Borisov wrote:
> > This series enables adding of a device when balance is paused (i.e an fs is mounted
> > with skip_balance options). This is needed to give users a chance to gracefully
> > handle an ENOSPC situation in the face of running balance. To achieve this introduce
> > a new exclop - BALANCE_PAUSED which is made compatible with device add. More
> > details in each patche.
> >
>
> Have you thought about allowing the device-add during the balance-running,
> not only at the balance-paused? Is it much complicated? If not, then we
> could drop the new exclop state BALANCE_PAUSED altogether.
>
We could be changing the raid settings, adding chunks before the new device is
added and then ending up with chunks that don't have all of their stripes. The
number of bugs that could show up is scary, I think this is the safer choice for
now. Thanks,
Josef
next prev parent reply other threads:[~2021-11-02 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 11:53 [PATCH 0/3] Balance vs device add fixes Nikolay Borisov
2021-11-01 11:53 ` [PATCH 1/3] btrfs: introduce BTRFS_EXCLOP_BALANCE_PAUSED exclusive state Nikolay Borisov
2021-11-01 11:53 ` [PATCH 2/3] btrfs: make device add compatible with paused balance in btrfs_exclop_start_try_lock Nikolay Borisov
2021-11-01 11:53 ` [PATCH 3/3] btrfs: allow device add if balance is paused Nikolay Borisov
2021-11-02 4:52 ` [PATCH 0/3] Balance vs device add fixes Anand Jain
2021-11-02 13:12 ` Josef Bacik [this message]
2021-11-02 14:30 ` Josef Bacik
2021-11-02 15:25 ` Nikolay Borisov
2021-11-02 16:10 ` Josef Bacik
2021-11-02 17:25 ` Goldwyn Rodrigues
2021-11-02 17:39 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYE5MB31cKGy0KD1@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.