From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tsuchiya Yuto <kitakar@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Patrik Gfeller <patrik.gfeller@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Kaixu Xia <kaixuxia@tencent.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Yang Li <abaci-bugfix@linux.alibaba.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Alex Dewar <alex.dewar90@gmail.com>,
Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Alan <alan@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-staging@lists.linux.dev,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe
Date: Tue, 2 Nov 2021 17:49:17 +0200 [thread overview]
Message-ID: <YYFd/Zb4aT3Qfjpi@smile.fi.intel.com> (raw)
In-Reply-To: <20211102150523.GJ2794@kadam>
On Tue, Nov 02, 2021 at 06:05:23PM +0300, Dan Carpenter wrote:
> On Tue, Nov 02, 2021 at 04:45:20PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 2, 2021 at 4:44 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > > > On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
...
> > > > Run your patches through scripts/checkpatch.pl.
> > >
> > > While it's good advice, we are dealing with quite a bad code under
> > > staging, so the requirements may be relaxed.
> >
> > To be more clear: the goal now is getting it _working_. That's why
> > this kind of noise is not important _for now_.
>
> If it's a new driver, then we accept all sorts of garbage, that's true.
It was in kernel for a while, but never worked (hence anyhow tested)
up to the recent effort made by Tsuchiya.
In any case, as I said, we shall run checkpatch in the future when
we have something working.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-02 16:04 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 16:23 [BUG 0/5] bug reports for atomisp to make it work Tsuchiya Yuto
2021-10-17 16:23 ` Tsuchiya Yuto
2021-10-17 16:23 ` [BUG/RFC PATCH 1/5] [BUG][RFC] media: atomisp: pci: assume run_mode is PREVIEW Tsuchiya Yuto
2021-10-17 16:23 ` Tsuchiya Yuto
2021-10-29 9:02 ` Mauro Carvalho Chehab
2021-11-11 8:00 ` Tsuchiya Yuto
2021-10-17 16:23 ` [BUG/RFC PATCH 2/5] [BUG][RFC] media: atomisp: pci: remove dummy_ptr NULL check to avoid duplicate active_bo Tsuchiya Yuto
2021-10-17 16:23 ` Tsuchiya Yuto
2022-02-08 6:19 ` Mauro Carvalho Chehab
2021-10-17 16:23 ` [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe Tsuchiya Yuto
2021-10-17 16:23 ` Tsuchiya Yuto
2021-11-02 13:02 ` Dan Carpenter
2021-11-02 14:44 ` Andy Shevchenko
2021-11-02 14:45 ` Andy Shevchenko
2021-11-02 15:05 ` Dan Carpenter
2021-11-02 15:49 ` Andy Shevchenko [this message]
2021-11-02 22:52 ` Mauro Carvalho Chehab
2021-11-08 15:48 ` Tsuchiya Yuto
2021-10-17 16:23 ` [BUG 4/5] [BUG] media: atomisp: `modprobe -r` not working well (dup video4linux, ATOMISP_SUBDEV_{0,1}) Tsuchiya Yuto
2021-10-17 16:23 ` Tsuchiya Yuto
2021-10-17 16:23 ` [BUG 5/5] [BUG] media: atomisp: atomisp causes touchscreen to stop working on Microsoft Surface 3 Tsuchiya Yuto
2021-10-17 16:23 ` Tsuchiya Yuto
2021-10-18 8:30 ` Hans de Goede
2021-10-21 9:52 ` Tsuchiya Yuto
2021-10-24 8:32 ` Hans de Goede
2021-10-26 9:35 ` Tsuchiya Yuto
2021-10-26 15:41 ` Hans de Goede
2021-10-27 16:07 ` Tsuchiya Yuto
2021-11-07 23:39 ` Hans de Goede
2021-11-08 7:41 ` Mauro Carvalho Chehab
2021-11-08 7:55 ` Hans de Goede
2021-11-08 8:01 ` Mauro Carvalho Chehab
2021-11-09 4:18 ` Tsuchiya Yuto
2021-11-09 9:08 ` Mauro Carvalho Chehab
2021-11-09 4:15 ` Tsuchiya Yuto
2021-11-09 7:35 ` Mauro Carvalho Chehab
2021-10-18 7:50 ` [BUG 0/5] bug reports for atomisp to make it work Hans de Goede
2021-10-18 8:10 ` Andy Shevchenko
2021-10-19 12:58 ` Tsuchiya Yuto
2021-10-19 14:06 ` Andy Shevchenko
2021-10-20 6:48 ` Mauro Carvalho Chehab
2021-10-20 12:35 ` Tsuchiya Yuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYFd/Zb4aT3Qfjpi@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=alan@linux.intel.com \
--cc=alex.dewar90@gmail.com \
--cc=alinesantanacordeiro@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kaixuxia@tencent.com \
--cc=kitakar@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mingo@kernel.org \
--cc=patrik.gfeller@gmail.com \
--cc=peterz@infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.