Re: [PATCH] erofs: fix deadlock when shrink erofs slab

From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Huang Jianan <huangjianan@oppo.com>
Cc: zhangshiming@oppo.com, yh@oppo.com, guanyuwei@oppo.com,
	guoweichao@oppo.com, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs: fix deadlock when shrink erofs slab
Date: Fri, 19 Nov 2021 10:19:16 +0800	[thread overview]
Message-ID: <YZcJpDs3FKpSfzAE@B-P7TQMD6M-0146> (raw)
In-Reply-To: <20211118135844.3559-1-huangjianan@oppo.com>

On Thu, Nov 18, 2021 at 09:58:44PM +0800, Huang Jianan wrote:
> We observed the following deadlock in the stress test under low
> memory scenario:
> 
> Thread A                               Thread B
> - erofs_shrink_scan
>  - erofs_try_to_release_workgroup
>   - erofs_workgroup_try_to_freeze -- A
>                                        - z_erofs_do_read_page
>                                         - z_erofs_collection_begin
>                                          - z_erofs_register_collection
>                                           - erofs_insert_workgroup
>                                            - xa_lock(&sbi->managed_pslots) -- B
>                                            - erofs_workgroup_get
>                                             - erofs_wait_on_workgroup_freezed -- A
>   - xa_erase
>    - xa_lock(&sbi->managed_pslots) -- B
> 
> To fix this, it need to hold the xa lock before freeze the workgroup
> beacuse we will operate xarry. So let's hold the lock before access
  ^ because               ^ xarray

> each workgroup, just like when we using the radix tree before.
> 
> Fixes: 64094a04414f ("erofs: convert workstn to XArray")
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang