Re: [PATCH v2] kselftest: alsa: Add simplistic test for ALSA mixer controls kselftest

From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2] kselftest: alsa: Add simplistic test for ALSA mixer controls kselftest
Date: Mon, 6 Dec 2021 18:17:08 +0000	[thread overview]
Message-ID: <Ya5TpDyUBH0pImY1@sirena.org.uk> (raw)
In-Reply-To: <b2972e61-e6c2-9f60-6242-3762c88efe0a@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

On Mon, Dec 06, 2021 at 11:01:25AM -0600, Pierre-Louis Bossart wrote:

> > It's not really idiomatic for kselftest to require any per system
> > configuration by default - half the thing is that you can just run it
> > and it should do as much as it can sensibly on the system.  You could
> > definitely add some command line options for development or manual usage
> > though.

> I was thinking of adding this test to our CI, it's a bit orthogonal to
> self-tests indeed. IIRC we check that we can modify all the PGA settings

I do think it's useful to run there, it'd give coverage for all the
CODEC drivers in your systems and of course for controls added for the
DSPs.

> for volume control but this test is a lot more generic.

It should be fine to run in your CI as it is - assuming there's no bugs
it finds in the USB cards anyway.  It tries to leave the card in the
state it found it in so providing we can read and write whatever the
current settings are it should leave things configured as they were.
I'm not against adding an option to run on specific cards, you'd have to
run it outside of the kselftest harness for that but that's more of a
thing for your CI anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]