From: Rob Herring <robh@kernel.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Amit Kucheria <amitk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: Fix definition of cooling-maps contribution property
Date: Mon, 29 Nov 2021 14:30:22 -0600 [thread overview]
Message-ID: <YaU4XuiaJgEjGCdQ@robh.at.kernel.org> (raw)
In-Reply-To: <20211109103045.1403686-1-niklas.soderlund+renesas@ragnatech.se>
On Tue, 09 Nov 2021 11:30:45 +0100, Niklas Söderlund wrote:
> When converting the thermal-zones bindings to yaml the definition of the
> contribution property changed. The intention is the same, an integer
> value expressing a ratio of a sum on how much cooling is provided by the
> device to the zone. But after the conversion the integer value is
> limited to the range 0 to 100 and expressed as a percentage.
>
> This is problematic for two reasons.
>
> - This do not match how the binding is used. Out of the 18 files that
> make use of the property only two (ste-dbx5x0.dtsi and
> ste-hrefv60plus.dtsi) sets it at a value that satisfy the binding,
> 100. The remaining 16 files set the value higher and fail to validate.
>
> - Expressing the value as a percentage instead of a ratio of the sum is
> confusing as there is nothing to enforce the sum in the zone is not
> greater then 100.
>
> This patch restore the pre yaml conversion description and removes the
> value limitation allowing the usage of the bindings to validate.
>
> Fixes: 1202a442a31fd2e5 ("dt-bindings: thermal: Add yaml bindings for thermal zones")
> Reported-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> .../devicetree/bindings/thermal/thermal-zones.yaml | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2021-11-29 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 10:30 [PATCH] dt-bindings: thermal: Fix definition of cooling-maps contribution property Niklas Söderlund
2021-11-29 20:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaU4XuiaJgEjGCdQ@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.