From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Avihai Horon <avihaih@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Mark Zhang <markzhang@nvidia.com>
Subject: Re: [PATCH rdma-next v1 1/3] RDMA/core: Modify rdma_query_gid() to return accurate error codes
Date: Thu, 9 Dec 2021 20:17:11 +0200 [thread overview]
Message-ID: <YbJIJ7Lh95v8xAad@unreal> (raw)
In-Reply-To: <1f2b65dfb4d995e74b621e3e21e7c7445d187956.1639055490.git.leonro@nvidia.com>
On Thu, Dec 09, 2021 at 03:16:05PM +0200, Leon Romanovsky wrote:
> From: Avihai Horon <avihaih@nvidia.com>
>
> Modify rdma_query_gid() to return -ENOENT for empty entries. This will
> make error reporting more accurate and will be used in next patches.
>
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>
> Reviewed-by: Mark Zhang <markzhang@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/core/cache.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
> index 0c98dd3dee67..edddcca62ece 100644
> --- a/drivers/infiniband/core/cache.c
> +++ b/drivers/infiniband/core/cache.c
> @@ -955,7 +955,7 @@ int rdma_query_gid(struct ib_device *device, u32 port_num,
> {
> struct ib_gid_table *table;
> unsigned long flags;
> - int res = -EINVAL;
> + int res;
>
> if (!rdma_is_port_valid(device, port_num))
> return -EINVAL;
> @@ -963,9 +963,15 @@ int rdma_query_gid(struct ib_device *device, u32 port_num,
> table = rdma_gid_table(device, port_num);
> read_lock_irqsave(&table->rwlock, flags);
>
> - if (index < 0 || index >= table->sz ||
> - !is_gid_entry_valid(table->data_vec[index]))
> + if (index < 0 || index >= table->sz) {
> + res = -EINVAL
Jason,
I made stupid mistake here, and missed ";".
Can you fix it locally?
Thanks
> goto done;
> + }
> +
> + if (!is_gid_entry_valid(table->data_vec[index])) {
> + res = -ENOENT;
> + goto done;
> + }
>
> memcpy(gid, &table->data_vec[index]->attr.gid, sizeof(*gid));
> res = 0;
> --
> 2.33.1
>
next prev parent reply other threads:[~2021-12-09 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 13:16 [PATCH rdma-next v1 0/3] Skip holes in GID table Leon Romanovsky
2021-12-09 13:16 ` [PATCH rdma-next v1 1/3] RDMA/core: Modify rdma_query_gid() to return accurate error codes Leon Romanovsky
2021-12-09 18:17 ` Leon Romanovsky [this message]
2021-12-09 13:16 ` [PATCH rdma-next v1 2/3] RDMA/core: Let ib_find_gid() continue search even after empty entry Leon Romanovsky
2021-12-09 13:16 ` [PATCH rdma-next v1 3/3] RDMA/cma: Let cma_resolve_ib_dev() " Leon Romanovsky
2021-12-15 0:12 ` [PATCH rdma-next v1 0/3] Skip holes in GID table Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbJIJ7Lh95v8xAad@unreal \
--to=leon@kernel.org \
--cc=avihaih@nvidia.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.