Re: [PATCH -next] selftests: gpio: gpio-sim: avoid forking test twice

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Shuah Khan <shuah@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH -next] selftests: gpio: gpio-sim: avoid forking test twice
Date: Tue, 14 Dec 2021 14:04:01 +0200	[thread overview]
Message-ID: <YbiIMcf3VGCkPrdc@smile.fi.intel.com> (raw)
In-Reply-To: <20211214080919.22616-1-brgl@bgdev.pl>

On Tue, Dec 14, 2021 at 09:09:19AM +0100, Bartosz Golaszewski wrote:
> Use '-o' within [] in order to avoid spawning two processes for test.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks!

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
>  tools/testing/selftests/gpio/gpio-sim.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh
> index c913d5aec768..341e3de00896 100755
> --- a/tools/testing/selftests/gpio/gpio-sim.sh
> +++ b/tools/testing/selftests/gpio/gpio-sim.sh
> @@ -23,7 +23,7 @@ remove_chip() {
>  
>  	for FILE in $CONFIGFS_DIR/$CHIP/*; do
>  		BANK=`basename $FILE`
> -		if [ "$BANK" = "live" ] || [ "$BANK" = "dev_name" ]; then
> +		if [ "$BANK" = "live" -o "$BANK" = "dev_name" ]; then
>  			continue
>  		fi
>  
> -- 
> 2.30.1
> 

-- 
With Best Regards,
Andy Shevchenko