Re: [PATCH v2] of/fdt: Don't worry about non-memory region overlap for no-map

From: Mike Rapoport <rppt@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Quentin Perret <qperret@google.com>,
	Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2] of/fdt: Don't worry about non-memory region overlap for no-map
Date: Wed, 15 Dec 2021 12:01:59 +0200	[thread overview]
Message-ID: <Ybm9F5AdCSGz6IwN@kernel.org> (raw)
In-Reply-To: <Ybm6KQiS7B28QOSW@kernel.org>

On Wed, Dec 15, 2021 at 11:49:37AM +0200, Mike Rapoport wrote:
> 
> On Tue, Dec 14, 2021 at 11:20:11PM -0800, Stephen Boyd wrote:
> > @@ -482,9 +482,11 @@ static int __init early_init_dt_reserve_memory_arch(phys_addr_t base,
> >  	if (nomap) {
> >  		/*
> >  		 * If the memory is already reserved (by another region), we
> > -		 * should not allow it to be marked nomap.
> > +		 * should not allow it to be marked nomap, but don't worry
> > +		 * if the region isn't memory as it won't be mapped.
> >  		 */
> > -		if (memblock_is_region_reserved(base, size))
> > +		if (memblock_overlaps_region(&memblock.memory, base, size) &&
> > +		    memblock_is_region_reserved(base, size))

One more small thing. Maybe add pr_warn() here?

> >  			return -EBUSY;
> >  
> >  		return memblock_mark_nomap(base, size);

-- 
Sincerely yours,
Mike.