Re: [PATCH] hwmon: (dell-smm) Fix warning on /proc/i8k creation error

From: Greg KH <gregkh@linuxfoundation.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: pali@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Fix warning on /proc/i8k creation error
Date: Wed, 15 Dec 2021 14:54:41 +0100	[thread overview]
Message-ID: <YbnzoesmSK4ETHho@kroah.com> (raw)
In-Reply-To: <20211214210047.33489-1-W_Armin@gmx.de>

On Tue, Dec 14, 2021 at 10:00:47PM +0100, Armin Wolf wrote:
> commit dbd3e6eaf3d813939b28e8a66e29d81cdc836445 upstream.
> 
> The removal function is called regardless of whether
> /proc/i8k was created successfully or not, the later
> causing a WARN() on module removal.
> Fix that by only calling the removal function
> if /proc/i8k was created successfully.
> 
> Since the original patch depends on the driver
> registering a platform device, the backported patch
> stores the return value of proc_create() and only
> calls proc_remove_entry() on exit if proc_create()
> was successful.
> 
> Tested on a Inspiron 3505 for kernel 5.10.
> 
> Cc: <stable@vger.kernel.org> # 5.10.x
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

All now queued up, thanks.

greg k-h