From: Al Viro <viro@zeniv.linux.org.uk>
To: Stefan Roesch <shr@fb.com>
Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-team@fb.com, torvalds@linux-foundation.org,
christian.brauner@ubuntu.com
Subject: Re: [PATCH v10 2/5] fs: split off setxattr_copy and do_setxattr function from setxattr
Date: Thu, 30 Dec 2021 01:15:10 +0000 [thread overview]
Message-ID: <Yc0IHp2igNlXqyKV@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20211229203002.4110839-3-shr@fb.com>
On Wed, Dec 29, 2021 at 12:29:59PM -0800, Stefan Roesch wrote:
> + if (ctx->size) {
> + if (ctx->size > XATTR_SIZE_MAX)
> return -E2BIG;
> - kvalue = kvmalloc(size, GFP_KERNEL);
> - if (!kvalue)
> +
> + ctx->kvalue = kvmalloc(ctx->size, GFP_KERNEL);
> + if (!ctx->kvalue)
> return -ENOMEM;
> - if (copy_from_user(kvalue, value, size)) {
> - error = -EFAULT;
> - goto out;
> +
> + if (copy_from_user(ctx->kvalue, ctx->value, ctx->size)) {
> + kvfree(ctx->kvalue);
> + return -EFAULT;
BTW, what's wrong with using vmemdup_user() here?
next prev parent reply other threads:[~2021-12-30 1:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 20:29 [PATCH v10 0/5] io_uring: add xattr support Stefan Roesch
2021-12-29 20:29 ` [PATCH v10 1/5] fs: split off do_user_path_at_empty from user_path_at_empty() Stefan Roesch
2021-12-30 0:49 ` Al Viro
2021-12-30 19:57 ` Stefan Roesch
2021-12-29 20:29 ` [PATCH v10 2/5] fs: split off setxattr_copy and do_setxattr function from setxattr Stefan Roesch
2021-12-30 1:15 ` Al Viro [this message]
2021-12-30 9:41 ` Christian Brauner
2021-12-30 19:57 ` Stefan Roesch
2021-12-29 20:30 ` [PATCH v10 3/5] fs: split off do_getxattr from getxattr Stefan Roesch
2021-12-29 20:30 ` [PATCH v10 4/5] io_uring: add fsetxattr and setxattr support Stefan Roesch
2021-12-30 1:58 ` Al Viro
2021-12-30 2:17 ` Al Viro
2021-12-30 2:19 ` Al Viro
2021-12-30 3:04 ` Al Viro
2021-12-30 10:12 ` Christian Brauner
2021-12-30 16:16 ` Al Viro
2021-12-30 18:01 ` Christian Brauner
2021-12-30 19:09 ` Jens Axboe
2021-12-30 22:24 ` Al Viro
2021-12-30 22:46 ` Jens Axboe
2021-12-30 23:02 ` Al Viro
2021-12-30 20:18 ` Stefan Roesch
2021-12-29 20:30 ` [PATCH v10 5/5] io_uring: add fgetxattr and getxattr support Stefan Roesch
2021-12-30 1:41 ` Al Viro
2021-12-30 1:46 ` Al Viro
2021-12-30 20:01 ` Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc0IHp2igNlXqyKV@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=christian.brauner@ubuntu.com \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shr@fb.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.