From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: Ben Hutchings <ben@decadent.org.uk>,
Julius Werner <jwerner@chromium.org>,
Thierry Escande <thierry.escande@collabora.com>,
linux-kernel@vger.kernel.org,
Paul Menzel <pm.debian@googlemail.com>,
Mike Waychison <mikew@google.com>
Subject: Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware
Date: Tue, 21 Dec 2021 10:12:50 +0100 [thread overview]
Message-ID: <YcGakjioHqAFpLlE@kroah.com> (raw)
In-Reply-To: <Yb8u44SLN25A3ONT@eldamar.lan>
On Sun, Dec 19, 2021 at 02:08:51PM +0100, Salvatore Bonaccorso wrote:
> Hi,
>
> On Mon, Jun 18, 2018 at 11:55:40PM +0100, Ben Hutchings wrote:
> > The help text for GOOGLE_FIRMWARE states that it should only be
> > enabled when building a kernel for Google's own servers. However,
> > many of the drivers dependent on it are also useful on Chromebooks or
> > on any platform using coreboot.
> >
> > Update the help text to reflect this double duty.
> >
> > Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > v2: Mention coreboot, and don't touch GSMI help text
> >
> > drivers/firmware/google/Kconfig | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> > index f16b381a569c..ca049ecf5cfd 100644
> > --- a/drivers/firmware/google/Kconfig
> > +++ b/drivers/firmware/google/Kconfig
> > @@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
> > bool "Google Firmware Drivers"
> > default n
> > help
> > - These firmware drivers are used by Google's servers. They are
> > - only useful if you are working directly on one of their
> > - proprietary servers. If in doubt, say "N".
> > + These firmware drivers are used by Google servers,
> > + Chromebooks and other devices using coreboot firmware.
> > + If in doubt, say "N".
> >
> > if GOOGLE_FIRMWARE
>
> Prompted by a question downstream in Debian it looks that this patch
> never go applied.
>
> Is there anything missing for having it applied?
>
> Do you want a fresh resent of it?
I've picked it up now, thanks.
greg k-h
prev parent reply other threads:[~2021-12-21 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 22:55 [PATCH v2] firmware: Update Kconfig help text for Google firmware Ben Hutchings
2018-06-18 23:13 ` Julius Werner
2021-12-19 13:08 ` Salvatore Bonaccorso
2021-12-21 9:12 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcGakjioHqAFpLlE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ben@decadent.org.uk \
--cc=carnil@debian.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=pm.debian@googlemail.com \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.