Re: [PATCH v2 2/2] of: base: Improve argument length mismatch error

From: Rob Herring <robh@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] of: base: Improve argument length mismatch error
Date: Fri, 7 Jan 2022 17:30:31 -0600	[thread overview]
Message-ID: <YdjNF1cEmgOl3ho5@robh.at.kernel.org> (raw)
In-Reply-To: <f6a68e0088a552ea9dfd4d8e3b5b586d92594738.1640881913.git.baruch@tkos.co.il>

On Thu, 30 Dec 2021 18:31:53 +0200, Baruch Siach wrote:
> The cells_name field of of_phandle_iterator might be NULL. Use the
> phandle name instead. With this change instead of:
> 
>   OF: /soc/pinctrl@1000000: (null) = 3 found 2
> 
> We get:
> 
>   OF: /soc/pinctrl@1000000: phandle pinctrl@1000000 needs 3, found 2
> 
> Which is a more helpful messages making DT debugging easier.
> 
> In this particular example the phandle name looks like duplicate of the
> same node name. But note that the first node is the parent node
> (it->parent), while the second is the phandle target (it->node). They
> happen to be the same in the case that triggered this improvement. See
> commit 72cb4c48a46a ("arm64: dts: qcom: ipq6018: Fix gpio-ranges
> property").
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> Note that commit 72cb4c48a46a mentioned above is currently in the
> arm64-for-5.17 branch of the qcom git tree.
> 
> v2:
> 
>   Extend the commit log to explain the apparent node name duplication
> ---
>  drivers/of/base.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 

Applied, thanks!