From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: mchehab@kernel.org, robh@kernel.org,
sakari.ailus@linux.intel.com, geert@linux-m68k.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description
Date: Mon, 10 Jan 2022 15:10:02 +0200 [thread overview]
Message-ID: <YdwwKXrw+qICwIaW@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220110123804.377944-1-martin.kepplinger@puri.sm>
Hi Martin,
Thank you for the patch.
On Mon, Jan 10, 2022 at 01:38:03PM +0100, Martin Kepplinger wrote:
> This is supposed to fix "make dt_binding_check":
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
> camera@20: port:endpoint: Unevaluated properties are not allowed
> ('link-frequencies', 'data-lanes' were unexpected)
> From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>
> Link:
> https://lore.kernel.org/linux-media/CAL_JsqKzaZC0A4OwnMyAuEWm2pCcHyQxHyrBVtkiPNUeMDd+oA@mail.gmail.com/
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 85a8877c2f38..e61255cf3fb9 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -49,7 +49,7 @@ properties:
> description: Definition of the regulator used for the VDDD power supply.
>
> port:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/$defs/port-base
You also need to add
unevaluatedProperties: false
to reject any property that isn't defined in either port-base or in this
schema. Otherwise any extra property in the port node will be accepted.
>
> properties:
> endpoint:
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2022-01-10 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 12:38 [PATCH v1 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Martin Kepplinger
2022-01-10 12:38 ` [PATCH v1 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description Martin Kepplinger
2022-01-10 13:10 ` Laurent Pinchart
2022-01-10 13:10 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdwwKXrw+qICwIaW@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.