From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mmc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v4 1/3] block: simplify calling convention of elv_unregister_queue()
Date: Mon, 24 Jan 2022 23:25:32 -0800 [thread overview]
Message-ID: <Ye+l7K4peViBTOkX@infradead.org> (raw)
In-Reply-To: <20220124215938.2769-2-ebiggers@kernel.org>
On Mon, Jan 24, 2022 at 01:59:36PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Make elv_unregister_queue() a no-op if q->elevator is NULL or is not
> registered.
>
> This simplifies the existing callers, as well as the future caller in
> the error path of blk_register_queue().
>
> Also don't bother checking whether q is NULL, since it never is.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-01-25 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 21:59 [PATCH v4 0/3] block: show crypto capabilities in sysfs Eric Biggers
2022-01-24 21:59 ` [PATCH v4 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2022-01-25 7:25 ` Christoph Hellwig [this message]
2022-01-24 21:59 ` [PATCH v4 2/3] block: don't delete queue kobject before its children Eric Biggers
2022-01-25 7:26 ` Christoph Hellwig
2022-01-24 21:59 ` [PATCH v4 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2022-02-21 2:23 ` [PATCH v4 0/3] block: " Eric Biggers
2022-02-28 8:11 ` Eric Biggers
2022-02-28 13:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye+l7K4peViBTOkX@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.