From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: magnus.karlsson@intel.com, bjorn@kernel.org, ast@kernel.org,
daniel@iogearbox.net, netdev@vger.kernel.org,
jonathan.lemon@gmail.com, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests: xsk: fix rx_full stats test
Date: Fri, 21 Jan 2022 17:00:00 +0100 [thread overview]
Message-ID: <YerYgIFIqe8IM2YB@boxer> (raw)
In-Reply-To: <20220121123508.12759-1-magnus.karlsson@gmail.com>
On Fri, Jan 21, 2022 at 01:35:08PM +0100, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Fix the rx_full stats test so that it correctly reports pass even when
> the fill ring is not full of buffers.
>
> Fixes: 872a1184dbf2 ("selftests: xsk: Put the same buffer only once in the fill ring")
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Fixes xdpxceiver hang on my side.
Tested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> tools/testing/selftests/bpf/xdpxceiver.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c
> index 0a5d23da486d..ffa5502ad95e 100644
> --- a/tools/testing/selftests/bpf/xdpxceiver.c
> +++ b/tools/testing/selftests/bpf/xdpxceiver.c
> @@ -906,7 +906,10 @@ static bool rx_stats_are_valid(struct ifobject *ifobject)
> return true;
> case STAT_TEST_RX_FULL:
> xsk_stat = stats.rx_ring_full;
> - expected_stat -= RX_FULL_RXQSIZE;
> + if (ifobject->umem->num_frames < XSK_RING_PROD__DEFAULT_NUM_DESCS)
> + expected_stat = ifobject->umem->num_frames - RX_FULL_RXQSIZE;
> + else
> + expected_stat = XSK_RING_PROD__DEFAULT_NUM_DESCS - RX_FULL_RXQSIZE;
> break;
> case STAT_TEST_RX_FILL_EMPTY:
> xsk_stat = stats.rx_fill_ring_empty_descs;
>
> base-commit: 820e6e227c4053b6b631ae65ef1f65d560cb392b
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-01-21 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 12:35 [PATCH bpf-next] selftests: xsk: fix rx_full stats test Magnus Karlsson
2022-01-21 16:00 ` Maciej Fijalkowski [this message]
2022-01-24 16:49 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YerYgIFIqe8IM2YB@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.