From: Matthew Wilcox <willy@infradead.org>
To: Steve French <smfrench@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>,
linux-cachefs@redhat.com, Jeff Layton <jlayton@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] cifs: Implement cache I/O by accessing the cache directly
Date: Fri, 28 Jan 2022 00:58:06 +0000 [thread overview]
Message-ID: <YfM/ngiPN5wkwjii@casper.infradead.org> (raw)
In-Reply-To: <CAH2r5mu4FeX2x=Xd0jDnQopTfhOBP_P91-NH-A+bNdx6THCu8A@mail.gmail.com>
On Thu, Jan 27, 2022 at 06:55:23PM -0600, Steve French wrote:
> Regression tests so far on Dave's cifs fscache patch series are going
> fine. First series of tests I ran were this:
> http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/11/builds/160
> but I have to run additional tests with fscache enabled etc.
>
> I saw that checkpatch had some minor complaints on this patch (patch
> 4) which I cleaned up, but was wondering other's thoughts on this
> checkpatch warning:
>
> WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code
> rather than BUG() or BUG_ON()
> #101: FILE: fs/cifs/file.c:4449:
>
> ie
>
> + page = readahead_page(ractl);
> + BUG_ON(!page);
Just remove it. The kernel will crash just fine without putting in an
explicit BUG_ON, and it'll be obvious what the problem is.
next prev parent reply other threads:[~2022-01-28 0:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 16:01 [PATCH 0/4] cifs: Use fscache I/O again after the rewrite disabled it David Howells
2022-01-27 16:02 ` [PATCH 1/4] Fix a warning about a malformed kernel doc comment in cifs by removing the David Howells
2022-01-27 16:02 ` [PATCH 2/4] cifs: Transition from ->readpages() to ->readahead() David Howells
2022-01-27 16:02 ` [PATCH 3/4] netfs, cachefiles: Add a method to query presence of data in the cache David Howells
2022-01-27 16:02 ` [PATCH 4/4] cifs: Implement cache I/O by accessing the cache directly David Howells
2022-01-28 0:55 ` Steve French
2022-01-28 0:58 ` Matthew Wilcox [this message]
2022-01-27 16:09 ` [PATCH 0/4] cifs: Use fscache I/O again after the rewrite disabled it David Howells
2022-01-28 10:58 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfM/ngiPN5wkwjii@casper.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.