From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] scsi: Add scsi_done_direct() for immediate completion.
Date: Thu, 3 Feb 2022 20:46:44 +0100 [thread overview]
Message-ID: <YfwxJPUFCo5/55yI@flow> (raw)
In-Reply-To: <c8402f76-7397-77c3-232c-c825c52ea826@acm.org>
On 2022-02-02 12:49:16 [-0800], Bart Van Assche wrote:
> On 2/1/22 13:09, Sebastian Andrzej Siewior wrote:
> > -void scsi_done(struct scsi_cmnd *cmd)
> > +static bool scsi_done_need_blk_compl(struct scsi_cmnd *cmd)
>
> I'm not happy about the name of this function. The word "need" in the
> function name suggests that this function does not modify any state.
> However, the body of the function shows that it may complete a SCSI command.
> How about renaming the existing scsi_done() function into
> scsi_done_internal() or so and adding a "bool complete_directly" argument to
> that function?
Let me see what I can do.
> BTW, I only received patch 1/2 but not patch 2/2. Please Cc the linux-scsi
> mailing list for the entire patch series when reposting the patch series.
I did and based on lore's archive it made it to the list:
https://lore.kernel.org/linux-scsi/20220201210954.570896-1-sebastian@breakpoint.cc/
> Thanks,
>
> Bart.
Sebastian
next prev parent reply other threads:[~2022-02-03 19:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 21:09 [PATCH 0/2] Add scsi_done_direct() to complete request directly Sebastian Andrzej Siewior
2022-02-01 21:09 ` [PATCH 1/2] scsi: Add scsi_done_direct() for immediate completion Sebastian Andrzej Siewior
2022-02-02 20:49 ` Bart Van Assche
2022-02-03 19:46 ` Sebastian Andrzej Siewior [this message]
2022-02-03 20:29 ` [PATCH v2 " Sebastian Andrzej Siewior
2022-02-03 22:30 ` Bart Van Assche
2022-02-03 22:27 ` [PATCH " Bart Van Assche
2022-02-01 21:09 ` [PATCH 2/2] usb: storage: Complete the scsi request directly Sebastian Andrzej Siewior
2022-02-08 4:14 ` [PATCH 0/2] Add scsi_done_direct() to complete " Martin K. Petersen
2022-02-11 23:25 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfwxJPUFCo5/55yI@flow \
--to=sebastian@breakpoint.cc \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.