From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] printk: defer_console_output: do not assume interrupts disabled
Date: Fri, 4 Feb 2022 16:04:07 +0900 [thread overview]
Message-ID: <YfzP50vDiJiaRVCr@google.com> (raw)
In-Reply-To: <20220203112915.1350753-1-john.ogness@linutronix.de>
On (22/02/03 12:35), John Ogness wrote:
> With commit 458df9fd4815 ("printk: remove separate printk_sched
> buffers and use printk buf instead") defer_console_output() was
> changed to no longer disable interrupts. However, it used the
> function __this_cpu_or(), which assumes interrupts disabled. That
> also should have been changed to this_cpu_or().
>
> Although defer_console_output() is mostly used when interrupts are
> disabled, this is not always the case. One example is
> get_random_bytes(), which is often called with interrupts enabled.
>
> get_random_bytes()
> warn_unseeded_randomness()
> printk_deferred()
>
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
next prev parent reply other threads:[~2022-02-04 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 11:29 [PATCH] printk: defer_console_output: do not assume interrupts disabled John Ogness
2022-02-03 11:33 ` Sebastian Andrzej Siewior
2022-02-04 7:04 ` Sergey Senozhatsky [this message]
2022-02-07 9:46 ` [PATCH v2] printk: defer_console_output: use atomic update John Ogness
2022-02-10 15:47 ` Petr Mladek
2022-02-11 11:22 ` John Ogness
2022-02-11 11:23 ` [PATCH v3] printk: use atomic updates for klogd work John Ogness
2022-02-14 5:35 ` Sergey Senozhatsky
2022-02-15 15:26 ` Petr Mladek
2022-02-14 5:32 ` [PATCH v2] printk: defer_console_output: use atomic update Sergey Senozhatsky
2022-02-14 5:35 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfzP50vDiJiaRVCr@google.com \
--to=senozhatsky@chromium.org \
--cc=bigeasy@linutronix.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.