From: Thierry Reding <thierry.reding@gmail.com>
To: Wayne Chang <waynec@nvidia.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
jonathanh@nvidia.com, zhangqilong3@huawei.com,
yangyingliang@huawei.com, rikard.falkeborn@gmail.com,
chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Do not program SPARAM
Date: Fri, 25 Feb 2022 14:18:32 +0100 [thread overview]
Message-ID: <YhjXKLVYgpop27R9@orome> (raw)
In-Reply-To: <20220107090443.149021-1-waynec@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
On Fri, Jan 07, 2022 at 05:04:43PM +0800, Wayne Chang wrote:
> According to the Tegra Technical Reference Manual, SPARAM
> is a read-only register and should not be programmed in
> the driver.
>
> The change removes the wrong SPARAM usage.
>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 8 --------
> 1 file changed, 8 deletions(-)
What's the impact on this? Does it fix a bug? Or is it more of a
cosmetic change?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-02-25 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 9:04 [PATCH 1/1] usb: gadget: tegra-xudc: Do not program SPARAM Wayne Chang
2022-02-25 13:18 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhjXKLVYgpop27R9@orome \
--to=thierry.reding@gmail.com \
--cc=balbi@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=waynec@nvidia.com \
--cc=yangyingliang@huawei.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.