From: Thierry Reding <thierry.reding@gmail.com>
To: Wayne Chang <waynec@nvidia.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
jonathanh@nvidia.com, zhangqilong3@huawei.com,
yangyingliang@huawei.com, rikard.falkeborn@gmail.com,
chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Fix control endpoint's definitions
Date: Fri, 25 Feb 2022 14:20:21 +0100 [thread overview]
Message-ID: <YhjXlQJoKzI/9q89@orome> (raw)
In-Reply-To: <20220107091349.149798-1-waynec@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Fri, Jan 07, 2022 at 05:13:49PM +0800, Wayne Chang wrote:
> According to the Tegra Technical Reference Manual, the seq_num
> field of control endpoint is not [31:24] but [31:27]. Bit 24
> is reserved and bit 26 is splitxstate.
>
> The change fixes the wrong control endpoint's definitions.
>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Again, what's the impact of this? Is this a critical bug fix that needs
to go into stable? Or is it cleanup? Perhaps add something along those
lines to the commit message to make it clearer to maintainers how they
need to deal with them.
Also, if this is a bugfix, make sure to Cc: stable@vger.kernel.org and
add a corresponding Fixes: line. Same for that earlier patch.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-02-25 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 9:13 [PATCH 1/1] usb: gadget: tegra-xudc: Fix control endpoint's definitions Wayne Chang
2022-02-25 13:20 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhjXlQJoKzI/9q89@orome \
--to=thierry.reding@gmail.com \
--cc=balbi@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=waynec@nvidia.com \
--cc=yangyingliang@huawei.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.