From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Marek Behún" <kabel@kernel.org>
Cc: Kurt Cancemi <kurt@x64architecture.com>,
netdev@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH v2 net] net: phy: marvell: Fix invalid comparison in the resume and suspend functions.
Date: Sat, 12 Mar 2022 20:16:16 +0000 [thread overview]
Message-ID: <Yiz/kEe9TkJstGR1@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220312203038.5a67bdc7@thinkpad>
On Sat, Mar 12, 2022 at 08:30:38PM +0100, Marek Behún wrote:
> On Fri, 11 Mar 2022 19:20:19 -0500
> Kurt Cancemi <kurt@x64architecture.com> wrote:
>
> > This bug resulted in only the current mode being resumed and suspended when
> > the PHY supported both fiber and copper modes and when the PHY only supported
> > copper mode the fiber mode would incorrectly be attempted to be resumed and
> > suspended.
> >
> > Fixes: 3758be3dc162 ("Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links.")
> > Signed-off-by: Kurt Cancemi <kurt@x64architecture.com>
>
> Nitpick: We don't use dots to end subject lines.
However, the commit in question has, and the Fixes: quoted summary line
needs to exactly match the summary line from the commit in question. So,
the fixes line is unfortunately correct in this instance.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-03-12 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 0:20 [PATCH v2 net] net: phy: marvell: Fix invalid comparison in the resume and suspend functions Kurt Cancemi
2022-03-12 15:15 ` Andrew Lunn
2022-03-12 19:30 ` Marek Behún
2022-03-12 20:16 ` Russell King (Oracle) [this message]
2022-03-12 20:15 ` [PATCH net v3] " Kurt Cancemi
2022-03-12 20:25 ` Andrew Lunn
2022-03-14 22:07 ` Jakub Kicinski
2022-03-14 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yiz/kEe9TkJstGR1@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=kabel@kernel.org \
--cc=kurt@x64architecture.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.