Re: [PATCH v3] mm: Only re-generate demotion targets when a numa node changes its N_CPU state

From: Oscar Salvador <osalvador@suse.de>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Abhishek Goel <huntbag@linux.vnet.ibm.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm: Only re-generate demotion targets when a numa node changes its N_CPU state
Date: Tue, 15 Mar 2022 09:32:42 +0100	[thread overview]
Message-ID: <YjBPKmIpPNoJU/67@localhost.localdomain> (raw)
In-Reply-To: <87pmmn3eh6.fsf@yhuang6-desk2.ccr.corp.intel.com>

On Tue, Mar 15, 2022 at 02:40:53PM +0800, Huang, Ying wrote:
> Oscar Salvador <osalvador@suse.de> writes:
> CPUHP_MM_DEMOTION_DEAD and CPUHP_AP_MM_DEMOTION_ONLINE needs to be
> deleted from include/linux/cpuhotplug.h too.

Hi Huang Ying,

Right.

Andrew, can you apply this on top? Thanks

diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
index 411a428ace4d..8a9a2d01b7c6 100644
--- a/include/linux/cpuhotplug.h
+++ b/include/linux/cpuhotplug.h
@@ -72,8 +72,6 @@ enum cpuhp_state {
 	CPUHP_SLUB_DEAD,
 	CPUHP_DEBUG_OBJ_DEAD,
 	CPUHP_MM_WRITEBACK_DEAD,
-	/* Must be after CPUHP_MM_VMSTAT_DEAD */
-	CPUHP_MM_DEMOTION_DEAD,
 	CPUHP_MM_VMSTAT_DEAD,
 	CPUHP_SOFTIRQ_DEAD,
 	CPUHP_NET_MVNETA_DEAD,
@@ -244,8 +242,6 @@ enum cpuhp_state {
 	CPUHP_AP_BASE_CACHEINFO_ONLINE,
 	CPUHP_AP_ONLINE_DYN,
 	CPUHP_AP_ONLINE_DYN_END		= CPUHP_AP_ONLINE_DYN + 30,
-	/* Must be after CPUHP_AP_ONLINE_DYN for node_states[N_CPU] update */
-	CPUHP_AP_MM_DEMOTION_ONLINE,
 	CPUHP_AP_X86_HPET_ONLINE,
 	CPUHP_AP_X86_KVM_CLK_ONLINE,
 	CPUHP_AP_ACTIVE,

Huang Ying, it would be great to have your Reviewed-by/Acked-by if you
are ok with the outome.

Thanks

-- 
Oscar Salvador
SUSE Labs
