From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] spidev: Do not use atomic bit operations when allocating minor
Date: Wed, 23 Mar 2022 16:39:01 +0000 [thread overview]
Message-ID: <YjtNJe4Pgp3WIwOa@sirena.org.uk> (raw)
In-Reply-To: <20220323140215.2568-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
On Wed, Mar 23, 2022 at 04:02:12PM +0200, Andy Shevchenko wrote:
> There is no need to use atomic bit operations when allocating a minor
> number since it's done under a mutex. Moreover, one of the operations
> that is in use is non-atomic anyway.
> if (status == 0) {
> - set_bit(minor, minors);
> + __set_bit(minor, minors);
> list_add(&spidev->device_entry, &device_list);
There's no *need* but the __ looks suspicious... what's the upside
here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-23 16:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 14:02 [PATCH v1 1/4] spidev: Do not use atomic bit operations when allocating minor Andy Shevchenko
2022-03-23 14:02 ` [PATCH v1 2/4] spidev: Convert BUILD_BUG_ON() to static_assert() Andy Shevchenko
2022-03-23 14:02 ` [PATCH v1 3/4] spidev: Replace ACPI specific code by device_get_match_data() Andy Shevchenko
2022-03-23 14:02 ` [PATCH v1 4/4] spidev: Replace OF specific code by device property API Andy Shevchenko
2022-03-23 16:39 ` Mark Brown [this message]
2022-03-23 17:22 ` [PATCH v1 1/4] spidev: Do not use atomic bit operations when allocating minor Andy Shevchenko
2022-03-23 19:06 ` Mark Brown
2022-03-24 9:24 ` Andy Shevchenko
2022-03-24 14:28 ` Mark Brown
2022-03-25 11:09 ` Andy Shevchenko
2022-03-26 1:29 ` Yury Norov
2022-03-25 12:44 ` Andy Shevchenko
2022-03-25 13:26 ` Mark Brown
2022-03-25 13:44 ` Andy Shevchenko
2022-04-05 9:32 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjtNJe4Pgp3WIwOa@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.